New ARI warning Sat Mar 19 01:54:11 UTC 2011

New ARI warning Sat Mar 19 01:54:11 UTC 2011

[GDB Administrator]

15d14
< gdb/alpha-tdep.c:248: obsolete: frame_register_read: Replace frame_register_read() with get_frame_register(), or possibly introduce a new method safe_get_frame_register()
gdb/alpha-tdep.c:248:  frame_register_read (frame, regnum, in);
79,96d77
< gdb/c-exp.y:701: gettext: _ markup: All messages should be marked up with _.
gdb/c-exp.y:701:				    error ("Undefined string concatenation.");
< gdb/c-exp.y:740: gettext: _ markup: All messages should be marked up with _.
gdb/c-exp.y:740:			    error ("No file or function \"%s\".",
< gdb/c-exp.y:754: gettext: _ markup: All messages should be marked up with _.
gdb/c-exp.y:754:			    error ("No function \"%s\" in specified context.",
< gdb/c-exp.y:764: gettext: _ markup: All messages should be marked up with _.
gdb/c-exp.y:764:			    error ("No symbol \"%s\" in specified context.",
< gdb/c-exp.y:781: gettext: _ markup: All messages should be marked up with _.
gdb/c-exp.y:781:			    error ("`%s' is not defined as an aggregate type.",
< gdb/c-exp.y:797: gettext: _ markup: All messages should be marked up with _.
gdb/c-exp.y:797:			    error ("`%s' is not defined as an aggregate type.",
< gdb/c-exp.y:845: gettext: _ markup: All messages should be marked up with _.
gdb/c-exp.y:845:			    error ("No symbol table is loaded.  Use the \"file\" command.");
< gdb/c-exp.y:847: gettext: _ markup: All messages should be marked up with _.
gdb/c-exp.y:847:			    error ("No symbol \"%s\" in current context.", name);
< gdb/c-exp.y:897: gettext: _ markup: All messages should be marked up with _.
gdb/c-exp.y:897:				error ("No symbol table is loaded.  Use the \"file\" command.");
< gdb/c-exp.y:899: gettext: _ markup: All messages should be marked up with _.
gdb/c-exp.y:899:				error ("No symbol \"%s\" in current context.",
< gdb/c-exp.y:1530: gettext: _ markup: All messages should be marked up with _.
gdb/c-exp.y:1530:	    error ("Numeric constant too large.");
< gdb/c-exp.y:1847: gettext: _ markup: All messages should be marked up with _.
gdb/c-exp.y:1847:	error ("Unterminated string in expression.");
< gdb/c-exp.y:1849: gettext: _ markup: All messages should be marked up with _.
gdb/c-exp.y:1849:	error ("Unmatched single quote.");
< gdb/c-exp.y:2221: gettext: _ markup: All messages should be marked up with _.
gdb/c-exp.y:2221:	    error ("Invalid number \"%s\".", err_copy);
< gdb/c-exp.y:2264: gettext: _ markup: All messages should be marked up with _.
gdb/c-exp.y:2264:	      error ("Empty character constant.");
< gdb/c-exp.y:2272: gettext: _ markup: All messages should be marked up with _.
gdb/c-exp.y:2272:	      error ("Invalid character constant.");
< gdb/c-exp.y:2281: gettext: _ markup: All messages should be marked up with _.
gdb/c-exp.y:2281:    error ("Invalid character '%c' in expression.", c);
< gdb/c-exp.y:2661: gettext: _ markup: All messages should be marked up with _.
gdb/c-exp.y:2661:  error ("A %s in expression, near `%s'.", (msg ? msg : "error"), lexptr);
139,141d119
< gdb/common/signals.c:352: gettext: _ markup: All messages should be marked up with _.
gdb/common/signals.c:352:	error ("GDB bug: target.c (target_signal_from_host): "
< gdb/common/signals.c:647: gettext: _ markup: All messages should be marked up with _.
gdb/common/signals.c:647:      warning ("Signal %s does not exist on this system.\n",
< gdb/common/signals.c:670: gettext: _ markup: All messages should be marked up with _.
gdb/common/signals.c:670:  error ("Only signals 1-15 are valid as numeric signals.\n\
177,178d154
< gdb/darwin-nat-info.c:54: gettext: _ markup: All messages should be marked up with _.
gdb/darwin-nat-info.c:54:    error("%s must be specified with 0x...", what);		\
< gdb/darwin-nat.c:199: gettext: trailing new line: A message should not have a trailing new line
gdb/darwin-nat.c:199:  warning (_("Mach error at \"%s:%u\" in function \"%s\": %s (0x%lx)\n"),
254,258d229
< gdb/f-exp.y:520: gettext: _ markup: All messages should be marked up with _.
gdb/f-exp.y:520:				error ("No symbol table is loaded.  Use the \"file\" command.");
< gdb/f-exp.y:522: gettext: _ markup: All messages should be marked up with _.
gdb/f-exp.y:522:				error ("No symbol \"%s\" in current context.",
< gdb/f-exp.y:1102: gettext: _ markup: All messages should be marked up with _.
gdb/f-exp.y:1102:	    error ("Invalid number \"%s\".", err_copy);
< gdb/f-exp.y:1136: gettext: _ markup: All messages should be marked up with _.
gdb/f-exp.y:1136:    error ("Invalid character '%c' in expression.", c);
< gdb/f-exp.y:1227: gettext: _ markup: All messages should be marked up with _.
gdb/f-exp.y:1227:  error ("A %s in expression, near `%s'.", (msg ? msg : "error"), lexptr);
263,264d233
< gdb/frame.c:1039: obsolete: frame_register_read: Replace frame_register_read() with get_frame_register(), or possibly introduce a new method safe_get_frame_register()
gdb/frame.c:1039:	  if (!frame_register_read (frame, regnum, buf))
< gdb/frame.c:1082: obsolete: frame_register_read: Replace frame_register_read() with get_frame_register(), or possibly introduce a new method safe_get_frame_register()
gdb/frame.c:1082:	  frame_register_read (frame, regnum, buf);
356a326
> gdb/i386-tdep.c:1693: obsolete: frame_register_read: Replace frame_register_read() with get_frame_register(), or possibly introduce a new method safe_get_frame_register()
gdb/i386-tdep.c:1693:	  && frame_register_read (this_frame, cache->saved_sp_reg, buf))
375d344
< gdb/ia64-tdep.c:1205: obsolete: frame_register_read: Replace frame_register_read() with get_frame_register(), or possibly introduce a new method safe_get_frame_register()
gdb/ia64-tdep.c:1205:  frame_register_read (frame, regnum, in);
510,516d478
< gdb/m2-exp.y:332: gettext: _ markup: All messages should be marked up with _.
gdb/m2-exp.y:332:			{ error("Sets are not implemented.");}
< gdb/m2-exp.y:336: gettext: _ markup: All messages should be marked up with _.
gdb/m2-exp.y:336:			{ error("Sets are not implemented.");}
< gdb/m2-exp.y:340: gettext: _ markup: All messages should be marked up with _.
gdb/m2-exp.y:340:			{ error("Sets are not implemented.");}
< gdb/m2-exp.y:344: gettext: _ markup: All messages should be marked up with _.
gdb/m2-exp.y:344:			{ error("Sets are not implemented.");}
< gdb/m2-exp.y:346: gettext: _ markup: All messages should be marked up with _.
gdb/m2-exp.y:346:			{ error("Sets are not implemented.");}
< gdb/m2-exp.y:565: gettext: _ markup: All messages should be marked up with _.
gdb/m2-exp.y:565:			    error ("No function \"%s\" in specified context.",
< gdb/m2-exp.y:589: gettext: _ markup: All messages should be marked up with _.
gdb/m2-exp.y:589:			    error ("No symbol \"%s\" in specified context.",
518,522d479
< gdb/m2-exp.y:636: gettext: _ markup: All messages should be marked up with _.
gdb/m2-exp.y:636:				error ("No symbol table is loaded.  Use the \"symbol-file\" command.");
< gdb/m2-exp.y:638: gettext: _ markup: All messages should be marked up with _.
gdb/m2-exp.y:638:				error ("No symbol \"%s\" in current context.",
< gdb/m2-exp.y:695: gettext: _ markup: All messages should be marked up with _.
gdb/m2-exp.y:695:       error("Floating point numbers must be base 10.");
< gdb/m2-exp.y:697: gettext: _ markup: All messages should be marked up with _.
gdb/m2-exp.y:697:       error("Invalid digit \'%c\' in number.",p[c]);
< gdb/m2-exp.y:705: gettext: _ markup: All messages should be marked up with _.
gdb/m2-exp.y:705:	 error("Invalid digit \'%c\' in octal number.",c);
524d480
< gdb/m2-exp.y:908: gettext: _ markup: All messages should be marked up with _.
gdb/m2-exp.y:908:	 error("Unterminated string or character constant.");
527,532d482
< gdb/m2-exp.y:955: gettext: _ markup: All messages should be marked up with _.
gdb/m2-exp.y:955:	    error ("Invalid number \"%s\".", err_copy);
< gdb/m2-exp.y:964: gettext: _ markup: All messages should be marked up with _.
gdb/m2-exp.y:964:    error ("Invalid character '%c' in expression.", c);
< gdb/m2-exp.y:1041: gettext: _ markup: All messages should be marked up with _.
gdb/m2-exp.y:1041:	  error("internal:  Undefined class in m2lex()");
< gdb/m2-exp.y:1045: gettext: _ markup: All messages should be marked up with _.
gdb/m2-exp.y:1045:	  error("internal:  Unforseen case in m2lex()");
< gdb/m2-exp.y:1048: gettext: _ markup: All messages should be marked up with _.
gdb/m2-exp.y:1048:	  error ("unhandled token in m2lex()");
< gdb/m2-exp.y:1093: gettext: _ markup: All messages should be marked up with _.
gdb/m2-exp.y:1093:  error ("A %s in expression, near `%s'.", (msg ? msg : "error"), lexptr);
564d513
< gdb/mi/mi-interp.c:232: gettext: _ markup: All messages should be marked up with _.
gdb/mi/mi-interp.c:232:    error ("%s", mi_error_message);
567,581d515
< gdb/mi/mi-main.c:481: gettext: _ markup: All messages should be marked up with _.
gdb/mi/mi-main.c:481:      error ("%s", mi_error_message);
< gdb/mi/mi-main.c:492: gettext: _ markup: All messages should be marked up with _.
gdb/mi/mi-main.c:492:    error ("-thread-list-ids: No arguments required.");
< gdb/mi/mi-main.c:499: gettext: _ markup: All messages should be marked up with _.
gdb/mi/mi-main.c:499:      error ("%s", mi_error_message);
< gdb/mi/mi-main.c:507: gettext: _ markup: All messages should be marked up with _.
gdb/mi/mi-main.c:507:    error ("Invalid MI command");
< gdb/mi/mi-main.c:830: gettext: _ markup: All messages should be marked up with _.
gdb/mi/mi-main.c:830:	    error ("only '0' and '1' are valid values "
< gdb/mi/mi-main.c:842: gettext: _ markup: All messages should be marked up with _.
gdb/mi/mi-main.c:842:	error ("invalid syntax of group id '%s'", argv[optind]);
< gdb/mi/mi-main.c:847: gettext: _ markup: All messages should be marked up with _.
gdb/mi/mi-main.c:847:	error ("invalid syntax of group id '%s'", argv[optind]);
< gdb/mi/mi-main.c:868: gettext: _ markup: All messages should be marked up with _.
gdb/mi/mi-main.c:868:	error ("Non-existent thread group id '%d'", id);
< gdb/mi/mi-main.c:930: gettext: _ markup: All messages should be marked up with _.
gdb/mi/mi-main.c:930:	error ("bad register number");
< gdb/mi/mi-main.c:982: gettext: _ markup: All messages should be marked up with _.
gdb/mi/mi-main.c:982:	    error ("-data-list-changed-registers: "
< gdb/mi/mi-main.c:1001: gettext: _ markup: All messages should be marked up with _.
gdb/mi/mi-main.c:1001:	    error ("-data-list-changed-registers: "
< gdb/mi/mi-main.c:1007: gettext: _ markup: All messages should be marked up with _.
gdb/mi/mi-main.c:1007:	error ("bad register number");
< gdb/mi/mi-main.c:1061: gettext: _ markup: All messages should be marked up with _.
gdb/mi/mi-main.c:1061:    error ("-data-list-register-values: Usage: "
< gdb/mi/mi-main.c:1104: gettext: _ markup: All messages should be marked up with _.
gdb/mi/mi-main.c:1104:	error ("bad register number");
< gdb/mi/mi-main.c:1127: gettext: _ markup: All messages should be marked up with _.
gdb/mi/mi-main.c:1127:    error ("Optimized out");
583,594d516
< gdb/mi/mi-main.c:1186: gettext: _ markup: All messages should be marked up with _.
gdb/mi/mi-main.c:1186:    error ("-data-write-register-values: Usage: -data-write-register-"
< gdb/mi/mi-main.c:1192: gettext: _ markup: All messages should be marked up with _.
gdb/mi/mi-main.c:1192:    error ("-data-write-register-values: No registers.");
< gdb/mi/mi-main.c:1195: gettext: _ markup: All messages should be marked up with _.
gdb/mi/mi-main.c:1195:    error ("-data-write-register-values: No regs and values specified.");
< gdb/mi/mi-main.c:1198: gettext: _ markup: All messages should be marked up with _.
gdb/mi/mi-main.c:1198:    error ("-data-write-register-values: "
< gdb/mi/mi-main.c:1218: gettext: _ markup: All messages should be marked up with _.
gdb/mi/mi-main.c:1218:	error ("bad register number");
< gdb/mi/mi-main.c:1239: gettext: _ markup: All messages should be marked up with _.
gdb/mi/mi-main.c:1239:      error ("-data-evaluate-expression: "
< gdb/mi/mi-main.c:1326: gettext: _ markup: All messages should be marked up with _.
gdb/mi/mi-main.c:1326:    error ("-data-read-memory: Usage: "
< gdb/mi/mi-main.c:1363: gettext: _ markup: All messages should be marked up with _.
gdb/mi/mi-main.c:1363:    error ("-data-read-memory: invalid number of rows.");
< gdb/mi/mi-main.c:1368: gettext: _ markup: All messages should be marked up with _.
gdb/mi/mi-main.c:1368:    error ("-data-read-memory: invalid number of columns.");
< gdb/mi/mi-main.c:1387: gettext: _ markup: All messages should be marked up with _.
gdb/mi/mi-main.c:1387:    error ("Unable to read memory.");
< gdb/mi/mi-main.c:1510: gettext: _ markup: All messages should be marked up with _.
gdb/mi/mi-main.c:1510:    error ("Usage: [ -o OFFSET ] ADDR LENGTH.");
< gdb/mi/mi-main.c:1520: gettext: _ markup: All messages should be marked up with _.
gdb/mi/mi-main.c:1520:    error ("Unable to read memory.");
596,603d517
< gdb/mi/mi-main.c:1612: gettext: _ markup: All messages should be marked up with _.
gdb/mi/mi-main.c:1612:    error ("-data-write-memory: Usage: "
< gdb/mi/mi-main.c:1653: gettext: _ markup: All messages should be marked up with _.
gdb/mi/mi-main.c:1653:    error ("Usage: ADDR DATA.");
< gdb/mi/mi-main.c:1697: gettext: _ markup: All messages should be marked up with _.
gdb/mi/mi-main.c:1697:  error ("-enable-timings: Usage: %s {yes|no}", command);
< gdb/mi/mi-main.c:1721: gettext: _ markup: All messages should be marked up with _.
gdb/mi/mi-main.c:1721:  error ("-list-features should be passed no arguments");
< gdb/mi/mi-main.c:1741: gettext: _ markup: All messages should be marked up with _.
gdb/mi/mi-main.c:1741:  error ("-list-target-features should be passed no arguments");
< gdb/mi/mi-main.c:1776: gettext: _ markup: All messages should be marked up with _.
gdb/mi/mi-main.c:1776:    error ("-remove-inferior should be passed a single argument");
< gdb/mi/mi-main.c:1779: gettext: _ markup: All messages should be marked up with _.
gdb/mi/mi-main.c:1779:    error ("the thread group id is syntactically invalid");
< gdb/mi/mi-main.c:1783: gettext: _ markup: All messages should be marked up with _.
gdb/mi/mi-main.c:1783:    error ("the specified thread group does not exist");
672,680d585
< gdb/objc-exp.y:335: gettext: _ markup: All messages should be marked up with _.
gdb/objc-exp.y:335:			    error ("%s is not an ObjC Class", 
< gdb/objc-exp.y:628: gettext: _ markup: All messages should be marked up with _.
gdb/objc-exp.y:628:				error ("No file or function \"%s\".",
< gdb/objc-exp.y:639: gettext: _ markup: All messages should be marked up with _.
gdb/objc-exp.y:639:			    error ("No function \"%s\" in specified context.",
< gdb/objc-exp.y:649: gettext: _ markup: All messages should be marked up with _.
gdb/objc-exp.y:649:			    error ("No symbol \"%s\" in specified context.",
< gdb/objc-exp.y:664: gettext: _ markup: All messages should be marked up with _.
gdb/objc-exp.y:664:			    error ("`%s' is not defined as an aggregate type.",
< gdb/objc-exp.y:678: gettext: _ markup: All messages should be marked up with _.
gdb/objc-exp.y:678:			    error ("`%s' is not defined as an aggregate type.",
< gdb/objc-exp.y:682: gettext: _ markup: All messages should be marked up with _.
gdb/objc-exp.y:682:			    error ("invalid destructor `%s::~%s'",
< gdb/objc-exp.y:721: gettext: _ markup: All messages should be marked up with _.
gdb/objc-exp.y:721:			    error ("No symbol table is loaded.  "
< gdb/objc-exp.y:724: gettext: _ markup: All messages should be marked up with _.
gdb/objc-exp.y:724:			    error ("No symbol \"%s\" in current context.",
684,690d588
< gdb/objc-exp.y:775: gettext: _ markup: All messages should be marked up with _.
gdb/objc-exp.y:775:				error ("No symbol table is loaded.  "
< gdb/objc-exp.y:778: gettext: _ markup: All messages should be marked up with _.
gdb/objc-exp.y:778:				error ("No symbol \"%s\" in current context.",
< gdb/objc-exp.y:861: gettext: _ markup: All messages should be marked up with _.
gdb/objc-exp.y:861:			    error ("No symbol \"%s\" in current context.", 
< gdb/objc-exp.y:1105: gettext: _ markup: All messages should be marked up with _.
gdb/objc-exp.y:1105:	    error ("Numeric constant too large.");
< gdb/objc-exp.y:1270: gettext: _ markup: All messages should be marked up with _.
gdb/objc-exp.y:1270:	error ("Empty character constant.");
< gdb/objc-exp.y:1283: gettext: _ markup: All messages should be marked up with _.
gdb/objc-exp.y:1283:		error ("Unmatched single quote.");
< gdb/objc-exp.y:1288: gettext: _ markup: All messages should be marked up with _.
gdb/objc-exp.y:1288:	  error ("Invalid character constant.");
692,695d589
< gdb/objc-exp.y:1399: gettext: _ markup: All messages should be marked up with _.
gdb/objc-exp.y:1399:	    error ("Invalid number \"%s\".", err_copy);
< gdb/objc-exp.y:1437: gettext: _ markup: All messages should be marked up with _.
gdb/objc-exp.y:1437:	      error ("Missing '(' in @selector(...)");
< gdb/objc-exp.y:1452: gettext: _ markup: All messages should be marked up with _.
gdb/objc-exp.y:1452:	      error ("Missing ')' in @selector(...)");
< gdb/objc-exp.y:1513: gettext: _ markup: All messages should be marked up with _.
gdb/objc-exp.y:1513:	  error ("Unterminated string in expression.");
697d590
< gdb/objc-exp.y:1525: gettext: _ markup: All messages should be marked up with _.
gdb/objc-exp.y:1525:    error ("Invalid character '%c' in expression.", c);
703,704d595
< gdb/objc-exp.y:1783: gettext: _ markup: All messages should be marked up with _.
gdb/objc-exp.y:1783:    error("A %s near end of expression.",  (msg ? msg : "error"));
< gdb/objc-exp.y:1785: gettext: _ markup: All messages should be marked up with _.
gdb/objc-exp.y:1785:    error ("A %s in expression, near `%s'.", (msg ? msg : "error"), 
719,734d609
< gdb/p-exp.y:647: gettext: _ markup: All messages should be marked up with _.
gdb/p-exp.y:647:				error ("No file or function \"%s\".",
< gdb/p-exp.y:658: gettext: _ markup: All messages should be marked up with _.
gdb/p-exp.y:658:			    error ("No function \"%s\" in specified context.",
< gdb/p-exp.y:668: gettext: _ markup: All messages should be marked up with _.
gdb/p-exp.y:668:			    error ("No symbol \"%s\" in specified context.",
< gdb/p-exp.y:683: gettext: _ markup: All messages should be marked up with _.
gdb/p-exp.y:683:			    error ("`%s' is not defined as an aggregate type.",
< gdb/p-exp.y:717: gettext: _ markup: All messages should be marked up with _.
gdb/p-exp.y:717:			    error ("No symbol table is loaded.  "
< gdb/p-exp.y:720: gettext: _ markup: All messages should be marked up with _.
gdb/p-exp.y:720:			    error ("No symbol \"%s\" in current context.",
< gdb/p-exp.y:786: gettext: _ markup: All messages should be marked up with _.
gdb/p-exp.y:786:				error ("No symbol table is loaded.  "
< gdb/p-exp.y:789: gettext: _ markup: All messages should be marked up with _.
gdb/p-exp.y:789:				error ("No symbol \"%s\" in current context.",
< gdb/p-exp.y:964: gettext: _ markup: All messages should be marked up with _.
gdb/p-exp.y:964:	    error ("Numeric constant too large.");
< gdb/p-exp.y:1191: gettext: _ markup: All messages should be marked up with _.
gdb/p-exp.y:1191:	error ("Empty character constant.");
< gdb/p-exp.y:1204: gettext: _ markup: All messages should be marked up with _.
gdb/p-exp.y:1204:		error ("Unmatched single quote.");
< gdb/p-exp.y:1210: gettext: _ markup: All messages should be marked up with _.
gdb/p-exp.y:1210:	  error ("Invalid character constant.");
< gdb/p-exp.y:1302: gettext: _ markup: All messages should be marked up with _.
gdb/p-exp.y:1302:	    error ("Invalid number \"%s\".", err_copy);
< gdb/p-exp.y:1375: gettext: _ markup: All messages should be marked up with _.
gdb/p-exp.y:1375:	  error ("Unterminated string in expression.");
< gdb/p-exp.y:1387: gettext: _ markup: All messages should be marked up with _.
gdb/p-exp.y:1387:    error ("Invalid character '%c' in expression.", c);
< gdb/p-exp.y:1742: gettext: _ markup: All messages should be marked up with _.
gdb/p-exp.y:1742:  error ("A %s in expression, near `%s'.", (msg ? msg : "error"), lexptr);
764d638
< gdb/procfs.c:828: gettext: _ markup: All messages should be marked up with _.
gdb/procfs.c:828:  error ("%s", msg);
825,826d698
< gdb/python/py-cmd.c:200: gettext: _ markup: All messages should be marked up with _.
gdb/python/py-cmd.c:200:	  error ("%s", msg);
< gdb/python/py-value.c:482: gettext: _ markup: All messages should be marked up with _.
gdb/python/py-value.c:482:		  error( _("Cannot subscript requested type."));
837,838d708
< gdb/record.c:742: gettext: _ markup: All messages should be marked up with _.
gdb/record.c:742:                  warning ("Process record: error reading memory at "
< gdb/record.c:755: gettext: _ markup: All messages should be marked up with _.
gdb/record.c:755:                      warning ("Process record: error writing memory at "
840d709
< gdb/record.c:2157: gettext: trailing new line: A message should not have a trailing new line
gdb/record.c:2157:    error (_("Failed to read %d bytes from core file %s ('%s').\n"),
897d765
< gdb/remote.c:3540: gettext: _ markup: All messages should be marked up with _.
gdb/remote.c:3540:    warning ("Remote refused setting permissions with: %s", rs->buf);
900d767
< gdb/remote.c:4552: gettext: _ markup: All messages should be marked up with _.
gdb/remote.c:4552:	warning (" - Can't pass signal %d to target in reverse: ignored.\n",
1117d983
< gdb/top.c:1227: gettext: _ markup: All messages should be marked up with _.
gdb/top.c:1227:  qr = query ("%s", str);

Re: New ARI warning Sat Mar 19 01:54:11 UTC 2011

[Joel Brobecker]

This was a large diff, but in fact, there is only one new warning:

> gdb/i386-tdep.c:1693: obsolete: frame_register_read: Replace frame_register_read() with get_frame_register(), or possibly introduce a new method safe_get_frame_register()
gdb/i386-tdep.c:1693:     && frame_register_read (this_frame, cache->saved_sp_reg, buf))


-- 
Joel

Re: New ARI warning Sat Mar 19 01:54:11 UTC 2011

[Joel Brobecker]

> This was a large diff, but in fact, there is only one new warning:
> 
> > gdb/i386-tdep.c:1693: obsolete: frame_register_read: Replace frame_register_read() with get_frame_register(), or possibly introduce a new method safe_get_frame_register()
> gdb/i386-tdep.c:1693:     && frame_register_read (this_frame, cache->saved_sp_reg, buf))

I just had a look at this ARI warning.  The comment on
frame_register_read says:

/* FIXME: cagney/2003-02-02: Should be deprecated or replaced with a
   function called get_frame_register_p().  This slightly weird (and
   older) variant of get_frame_register() returns zero (indicating the
   register value is unavailable/invalid) if either: the register
   isn't cached; or the register has been optimized out; or the
   register contents are unavailable (because they haven't been
   collected in a traceframe).  Problem is, neither check is exactly
   correct.  A register can't be optimized out (it may not have been
   saved as part of a function call); The fact that a register isn't
   in the register cache doesn't mean that the register isn't
   available (it could have been fetched from memory).  */

I have had this feeling that we have way too many ways to read/write
frame registers, but I'm wondering if this comment might not be
too zealous in this case. This function seems useful, because it
returns a status as opposed to get_frame_register, which has the exact
same profile except that it throws instead of returning. So I'm thinking
we should remove the "deprecation" fixme, and just keep the FIXME for
fixing whatever incorrectness might be left, and then remove this from
the ARI.

Thoughts?

-- 
Joel

Re: New ARI warning Sat Mar 19 01:54:11 UTC 2011

[Pedro Alves]

On Wednesday 23 March 2011 17:16:01, Joel Brobecker wrote:
> > This was a large diff, but in fact, there is only one new warning:
> > 
> > > gdb/i386-tdep.c:1693: obsolete: frame_register_read: Replace frame_register_read() with get_frame_register(), or possibly introduce a new method safe_get_frame_register()
> > gdb/i386-tdep.c:1693:     && frame_register_read (this_frame, cache->saved_sp_reg, buf))
> 
> I just had a look at this ARI warning.  The comment on
> frame_register_read says:
> 
> /* FIXME: cagney/2003-02-02: Should be deprecated or replaced with a
>    function called get_frame_register_p().  This slightly weird (and
>    older) variant of get_frame_register() returns zero (indicating the
>    register value is unavailable/invalid) if either: the register
>    isn't cached; or the register has been optimized out; or the
>    register contents are unavailable (because they haven't been
>    collected in a traceframe).  Problem is, neither check is exactly
>    correct.  A register can't be optimized out (it may not have been
>    saved as part of a function call); The fact that a register isn't
>    in the register cache doesn't mean that the register isn't
>    available (it could have been fetched from memory).  */
> 
> I have had this feeling that we have way too many ways to read/write
> frame registers, but I'm wondering if this comment might not be
> too zealous in this case. This function seems useful, because it
> returns a status as opposed to get_frame_register, which has the exact
> same profile except that it throws instead of returning. So I'm thinking
> we should remove the "deprecation" fixme, and just keep the FIXME for
> fixing whatever incorrectness might be left, and then remove this from
> the ARI.
> 
> Thoughts?

Agreed.

-- 
Pedro Alves

Re: New ARI warning Sat Mar 19 01:54:11 UTC 2011

[Ulrich Weigand]

Pedro Alves wrote:
> On Wednesday 23 March 2011 17:16:01, Joel Brobecker wrote:
> > > This was a large diff, but in fact, there is only one new warning:
> > > 
> > > > gdb/i386-tdep.c:1693: obsolete: frame_register_read: Replace frame_register_read() with get_frame_register(), or possibly introduce a new method safe_get_frame_register()
> > > gdb/i386-tdep.c:1693:     && frame_register_read (this_frame, cache->saved_sp_reg, buf))
> > 
> > I just had a look at this ARI warning.  The comment on
> > frame_register_read says:
> > 
> > /* FIXME: cagney/2003-02-02: Should be deprecated or replaced with a
> >    function called get_frame_register_p().  This slightly weird (and
> >    older) variant of get_frame_register() returns zero (indicating the
> >    register value is unavailable/invalid) if either: the register
> >    isn't cached; or the register has been optimized out; or the
> >    register contents are unavailable (because they haven't been
> >    collected in a traceframe).  Problem is, neither check is exactly
> >    correct.  A register can't be optimized out (it may not have been
> >    saved as part of a function call); The fact that a register isn't
> >    in the register cache doesn't mean that the register isn't
> >    available (it could have been fetched from memory).  */
> > 
> > I have had this feeling that we have way too many ways to read/write
> > frame registers, but I'm wondering if this comment might not be
> > too zealous in this case. This function seems useful, because it
> > returns a status as opposed to get_frame_register, which has the exact
> > same profile except that it throws instead of returning. So I'm thinking
> > we should remove the "deprecation" fixme, and just keep the FIXME for
> > fixing whatever incorrectness might be left, and then remove this from
> > the ARI.
> > 
> > Thoughts?
> 
> Agreed.

I think that all users that require this additional status information
should just use the (new) get_frame_register_value, and look at that
value's properties.

So I do think that frame_register_read ought to stay deprecated;
we need to remove those extraneous frame register routines ...

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com

Re: New ARI warning Sat Mar 19 01:54:11 UTC 2011

[Joel Brobecker]

> I think that all users that require this additional status information
> should just use the (new) get_frame_register_value, and look at that
> value's properties.
> 
> So I do think that frame_register_read ought to stay deprecated;
> we need to remove those extraneous frame register routines ...

Pedro, if you agree, I'll add a comment to that effect next to
frame_register_read. Alternatively, we could try to reimplement
frame_register_read using get_frame_register_value, although
I get the impression that we wanted to start getting away from
reading into buffers.

-- 
Joel

Re: New ARI warning Sat Mar 19 01:54:11 UTC 2011

[Ulrich Weigand]

Joel Brobecker wrote:
> > I think that all users that require this additional status information
> > should just use the (new) get_frame_register_value, and look at that
> > value's properties.
> > 
> > So I do think that frame_register_read ought to stay deprecated;
> > we need to remove those extraneous frame register routines ...
> 
> Pedro, if you agree, I'll add a comment to that effect next to
> frame_register_read. Alternatively, we could try to reimplement
> frame_register_read using get_frame_register_value, although
> I get the impression that we wanted to start getting away from
> reading into buffers.

Oh, frame_register_read is already implemented in terms of
get_frame_register_value (well, frame_unwind_register_value
really, but that's the same thing).

I agree that the goal should be to push that implementation up
to the callers, and get rid of the buffer-based accessors.

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com