From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: brobecker@adacore.com (Joel Brobecker)
Cc: pedro@codesourcery.com (Pedro Alves), gdb-patches@sourceware.org
Subject: Re: New ARI warning Sat Mar 19 01:54:11 UTC 2011
Date: Fri, 25 Mar 2011 19:19:00 -0000 [thread overview]
Message-ID: <201103251625.p2PGPFHa010624@d06av02.portsmouth.uk.ibm.com> (raw)
In-Reply-To: <20110325155535.GP2520@adacore.com> from "Joel Brobecker" at Mar 25, 2011 08:55:35 AM
Joel Brobecker wrote:
> > I think that all users that require this additional status information
> > should just use the (new) get_frame_register_value, and look at that
> > value's properties.
> >
> > So I do think that frame_register_read ought to stay deprecated;
> > we need to remove those extraneous frame register routines ...
>
> Pedro, if you agree, I'll add a comment to that effect next to
> frame_register_read. Alternatively, we could try to reimplement
> frame_register_read using get_frame_register_value, although
> I get the impression that we wanted to start getting away from
> reading into buffers.
Oh, frame_register_read is already implemented in terms of
get_frame_register_value (well, frame_unwind_register_value
really, but that's the same thing).
I agree that the goal should be to push that implementation up
to the callers, and get rid of the buffer-based accessors.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
prev parent reply other threads:[~2011-03-25 16:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-19 17:32 GDB Administrator
2011-03-19 21:14 ` Joel Brobecker
2011-03-23 17:42 ` Joel Brobecker
2011-03-23 18:21 ` Pedro Alves
2011-03-24 18:32 ` Ulrich Weigand
2011-03-25 16:05 ` Joel Brobecker
2011-03-25 19:19 ` Ulrich Weigand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103251625.p2PGPFHa010624@d06av02.portsmouth.uk.ibm.com \
--to=uweigand@de.ibm.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox