Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [3/3, ppc64, bfd patch] eu-strip vs. func addresses for GDB inferior calls
@ 2011-03-23 16:42 Jan Kratochvil
  2011-03-24  3:11 ` Alan Modra
  0 siblings, 1 reply; 2+ messages in thread
From: Jan Kratochvil @ 2011-03-23 16:42 UTC (permalink / raw)
  To: binutils; +Cc: elfutils-devel, gdb-patches

Hi,

the bfd part.

The patch has been regression tested on:
	powerpc-eabisim powerpc-eabispe powerpc-elf powerpc-ibm-aix4.3.3.0
	powerpc-linux-gnu powerpc-nto powerpc-wrs-vxworks powerpc64-linux-gnu
	ppc-linux rs6000-aix4.3.3


Thanks,
Jan


bfd/
2011-03-23  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* elf64-ppc.c (ppc64_elf_get_synthetic_symtab): Do not check for
	SEC_LOAD.

--- a/bfd/elf64-ppc.c
+++ b/bfd/elf64-ppc.c
@@ -3317,8 +3317,9 @@ ppc64_elf_get_synthetic_symtab (bfd *abfd,
 		{
 		  if (sec->vma > ent)
 		    break;
-		  if ((sec->flags & SEC_ALLOC) == 0
-		      || (sec->flags & SEC_LOAD) == 0)
+		  /* SEC_LOAD may not be set if ABFD is a separate debug info
+		     file.  */
+		  if ((sec->flags & SEC_ALLOC) == 0)
 		    break;
 		  if ((sec->flags & SEC_CODE) != 0)
 		    s->section = sec;


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [3/3, ppc64, bfd patch] eu-strip vs. func addresses for GDB inferior calls
  2011-03-23 16:42 [3/3, ppc64, bfd patch] eu-strip vs. func addresses for GDB inferior calls Jan Kratochvil
@ 2011-03-24  3:11 ` Alan Modra
  0 siblings, 0 replies; 2+ messages in thread
From: Alan Modra @ 2011-03-24  3:11 UTC (permalink / raw)
  To: Jan Kratochvil; +Cc: binutils, elfutils-devel, gdb-patches

On Wed, Mar 23, 2011 at 04:30:22PM +0100, Jan Kratochvil wrote:
> 	* elf64-ppc.c (ppc64_elf_get_synthetic_symtab): Do not check for
> 	SEC_LOAD.

Not OK.  ppc64_elf_get_synthetic_symtab just doesn't work when ABFD is
a separate debug info file.

> --- a/bfd/elf64-ppc.c
> +++ b/bfd/elf64-ppc.c
> @@ -3317,8 +3317,9 @@ ppc64_elf_get_synthetic_symtab (bfd *abfd,
>  		{
>  		  if (sec->vma > ent)
>  		    break;
> -		  if ((sec->flags & SEC_ALLOC) == 0
> -		      || (sec->flags & SEC_LOAD) == 0)
> +		  /* SEC_LOAD may not be set if ABFD is a separate debug info
> +		     file.  */
> +		  if ((sec->flags & SEC_ALLOC) == 0)
>  		    break;
>  		  if ((sec->flags & SEC_CODE) != 0)
>  		    s->section = sec;

-- 
Alan Modra
Australia Development Lab, IBM


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-03-23 23:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-03-23 16:42 [3/3, ppc64, bfd patch] eu-strip vs. func addresses for GDB inferior calls Jan Kratochvil
2011-03-24  3:11 ` Alan Modra

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox