From: Alan Modra <amodra@gmail.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: binutils@sourceware.org, elfutils-devel@lists.fedorahosted.org,
gdb-patches@sourceware.org
Subject: Re: [3/3, ppc64, bfd patch] eu-strip vs. func addresses for GDB inferior calls
Date: Thu, 24 Mar 2011 03:11:00 -0000 [thread overview]
Message-ID: <20110323233841.GJ13754@bubble.grove.modra.org> (raw)
In-Reply-To: <20110323153022.GA13679@host1.jankratochvil.net>
On Wed, Mar 23, 2011 at 04:30:22PM +0100, Jan Kratochvil wrote:
> * elf64-ppc.c (ppc64_elf_get_synthetic_symtab): Do not check for
> SEC_LOAD.
Not OK. ppc64_elf_get_synthetic_symtab just doesn't work when ABFD is
a separate debug info file.
> --- a/bfd/elf64-ppc.c
> +++ b/bfd/elf64-ppc.c
> @@ -3317,8 +3317,9 @@ ppc64_elf_get_synthetic_symtab (bfd *abfd,
> {
> if (sec->vma > ent)
> break;
> - if ((sec->flags & SEC_ALLOC) == 0
> - || (sec->flags & SEC_LOAD) == 0)
> + /* SEC_LOAD may not be set if ABFD is a separate debug info
> + file. */
> + if ((sec->flags & SEC_ALLOC) == 0)
> break;
> if ((sec->flags & SEC_CODE) != 0)
> s->section = sec;
--
Alan Modra
Australia Development Lab, IBM
prev parent reply other threads:[~2011-03-23 23:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-23 16:42 Jan Kratochvil
2011-03-24 3:11 ` Alan Modra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110323233841.GJ13754@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=elfutils-devel@lists.fedorahosted.org \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox