Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org, ktietz70@googlemail.com,
	gcc-patches@gcc.gnu.org, binutils@sourceware.org
Subject: Re: [patch libiberty include]: Add additional helper functions for directory-separator searching
Date: Tue, 08 Mar 2011 18:54:00 -0000	[thread overview]
Message-ID: <201103081850.05721.pedro@codesourcery.com> (raw)
In-Reply-To: <838vwph30i.fsf@gnu.org>

On Tuesday 08 March 2011 18:37:49, Eli Zaretskii wrote:
> > > Another is in find_file_and_directory() in dwarf2read.c file.
> > 
> > Workaround for Irix.  Certainly that '/' should not depend
> > on the host gdb is running on.
> 
> It actually should use IS_ABSOLUTE_FILE_NAME, if any portability
> enhancement is needed here.

The point of the code, according to its comment,
is to workaround an issue with the debug info output by the
native Irix compiler.  You wouldn't want a cross-Irix,
Windows-hosted gdb looking for '\' or a drive prefix in order
to decide whether to apply the workaround.  In other words,
we _always_ want to check for literal '/' here:

  if (*comp_dir != NULL)
    {
      /* Irix 6.2 native cc prepends <machine>.: to the compilation
	 directory, get rid of it.  */
      char *cp = strchr (*comp_dir, ':');

      if (cp && cp != *comp_dir && cp[-1] == '.' && cp[1] == '/')
	*comp_dir = cp + 1;
    }

-- 
Pedro Alves


  reply	other threads:[~2011-03-08 18:50 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-08 11:25 Kai Tietz
2011-03-08 11:53 ` Eli Zaretskii
2011-03-08 11:55   ` Kai Tietz
2011-03-08 12:01     ` Eli Zaretskii
2011-03-08 12:48       ` Kai Tietz
2011-03-08 13:25         ` Pedro Alves
2011-03-08 13:33           ` Kai Tietz
2011-03-08 14:30             ` Pedro Alves
2011-03-08 14:45               ` Kai Tietz
2011-03-08 18:49               ` Eli Zaretskii
2011-03-08 18:54                 ` Pedro Alves [this message]
2011-03-08 18:58                 ` Kai Tietz
2011-03-08 19:59                   ` Eli Zaretskii
     [not found] ` <E1Pwupb-0001ns-M8__47566.5626036518$1299582745$gmane$org@fencepost.gnu.org>
2011-03-08 12:43   ` Andreas Schwab
2011-03-08 16:52 ` Kai Tietz
2011-03-08 17:02   ` Kai Tietz
2011-03-08 18:39     ` Eli Zaretskii
2011-03-08 19:51       ` DJ Delorie
2011-03-08 22:38         ` Eli Zaretskii
2011-03-08 23:10         ` Pedro Alves
2011-03-09  7:12           ` Eli Zaretskii
2011-03-09 12:40             ` Pedro Alves
2011-03-09 12:54               ` Eli Zaretskii
2011-03-09 13:39                 ` Pedro Alves
2011-03-09 13:54                   ` Eli Zaretskii
2011-03-12 22:59                     ` Kai Tietz
2011-03-09 15:02                   ` Build regression [Re: [patch libiberty include]: Add additional helper functions for directory-separator searching] Jan Kratochvil
2011-03-09 15:40                     ` Pedro Alves
2011-03-09 16:09                       ` Jan Kratochvil
2011-03-13  1:09         ` [patch libiberty include]: Add additional helper functions for directory-separator searching Kai Tietz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201103081850.05721.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=binutils@sourceware.org \
    --cc=eliz@gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=ktietz70@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox