From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: yao@codesourcery.com (Yao Qi)
Cc: gdb-patches@sourceware.org
Subject: Re: [patch, arm] Use cached dsc->is_thumb instead of re-computing
Date: Mon, 07 Mar 2011 15:50:00 -0000 [thread overview]
Message-ID: <201103071446.p27Ekib1001894@d06av02.portsmouth.uk.ibm.com> (raw)
In-Reply-To: <4D749DD9.8080703@codesourcery.com> from "Yao Qi" at Mar 07, 2011 04:56:57 PM
Yao Qi wrote:
> gdb/
> * arm-tdep.c (displaced_read_reg): Add `dsc' parameter, remove `from'
> parameter. Use cached result instead of calling displaced_in_arm_mode
> again.
> (branch_write_pc, alu_write_pc, load_write_pc): Add `dsc' parameter.
> (displaced_write_reg, copy_preload, copy_preload_reg): Callers update.
> (cleanup_copro_load_store, copy_copro_load_store): Likewise.
> (cleanup_branch, copy_bx_blx_reg, copy_alu_imm): Likewise.
> (cleanup_alu_reg, copy_alu_reg, cleanup_alu_shifted_reg): Likewise.
> (copy_alu_shifted_reg, cleanup_load, cleanup_store): Likewise.
> (copy_extra_ld_st, copy_ldr_str_ldrb_strb): Likewise.
> (cleanup_block_load_all, cleanup_block_store_pc): Likewise.
> (cleanup_block_load_pc, copy_block_xfer): Likewise.
> * arm-linux-tdep.c (arm_linux_copy_svc): Callers update.
> (arm_catch_kernel_helper_return): Likewise.
> * gdb/arm-tdep.h : Update function declarations.
There's a now-unused local variable "from" in arm_linux_copy_svc (you removed
those nearly everywhere, but apparently missed this one), and the recently-
added prototype declaration for displaced_read_reg is now unneeded again.
If you could remove those two as well, the patch is OK.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2011-03-07 14:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-04 13:30 Yao Qi
2011-03-04 14:08 ` Ulrich Weigand
2011-03-07 9:02 ` Yao Qi
2011-03-07 15:50 ` Ulrich Weigand [this message]
2011-03-07 15:55 ` Yao Qi
2011-03-07 16:22 ` Ulrich Weigand
2011-03-08 4:33 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103071446.p27Ekib1001894@d06av02.portsmouth.uk.ibm.com \
--to=uweigand@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox