From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: yao@codesourcery.com (Yao Qi)
Cc: gdb-patches@sourceware.org
Subject: Re: [patch, arm] Use cached dsc->is_thumb instead of re-computing
Date: Fri, 04 Mar 2011 14:08:00 -0000 [thread overview]
Message-ID: <201103041408.p24E824O026871@d06av02.portsmouth.uk.ibm.com> (raw)
In-Reply-To: <4D70E940.6090802@codesourcery.com> from "Yao Qi" at Mar 04, 2011 09:29:36 PM
Yao Qi wrote:
> During writing thumb displaced stepping, we find that displaced_read_reg
> can be refactored to avoid calling displaced_in_arm_mode every time.
Hmm, you now pass *both* DSC and FROM -- the latter is actually redundant
now, since every caller must pass in dsc->insn_addr as FROM anyway ...
Can you update the patch to pass DSC *instead of* FROM, and use
dsc->insn_addr internally?
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2011-03-04 14:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-04 13:30 Yao Qi
2011-03-04 14:08 ` Ulrich Weigand [this message]
2011-03-07 9:02 ` Yao Qi
2011-03-07 15:50 ` Ulrich Weigand
2011-03-07 15:55 ` Yao Qi
2011-03-07 16:22 ` Ulrich Weigand
2011-03-08 4:33 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103041408.p24E824O026871@d06av02.portsmouth.uk.ibm.com \
--to=uweigand@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox