From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20106 invoked by alias); 4 Mar 2011 14:08:12 -0000 Received: (qmail 20098 invoked by uid 22791); 4 Mar 2011 14:08:11 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mtagate4.uk.ibm.com (HELO mtagate4.uk.ibm.com) (194.196.100.164) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 Mar 2011 14:08:06 +0000 Received: from d06nrmr1707.portsmouth.uk.ibm.com (d06nrmr1707.portsmouth.uk.ibm.com [9.149.39.225]) by mtagate4.uk.ibm.com (8.13.1/8.13.1) with ESMTP id p24E83WT031734 for ; Fri, 4 Mar 2011 14:08:03 GMT Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by d06nrmr1707.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p24E8Fqj2007124 for ; Fri, 4 Mar 2011 14:08:16 GMT Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p24E83pR026935 for ; Fri, 4 Mar 2011 07:08:03 -0700 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with SMTP id p24E824O026871; Fri, 4 Mar 2011 07:08:02 -0700 Message-Id: <201103041408.p24E824O026871@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Fri, 04 Mar 2011 15:08:01 +0100 Subject: Re: [patch, arm] Use cached dsc->is_thumb instead of re-computing To: yao@codesourcery.com (Yao Qi) Date: Fri, 04 Mar 2011 14:08:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <4D70E940.6090802@codesourcery.com> from "Yao Qi" at Mar 04, 2011 09:29:36 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00293.txt.bz2 Yao Qi wrote: > During writing thumb displaced stepping, we find that displaced_read_reg > can be refactored to avoid calling displaced_in_arm_mode every time. Hmm, you now pass *both* DSC and FROM -- the latter is actually redundant now, since every caller must pass in dsc->insn_addr as FROM anyway ... Can you update the patch to pass DSC *instead of* FROM, and use dsc->insn_addr internally? Thanks, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com