From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7994 invoked by alias); 7 Mar 2011 14:47:02 -0000 Received: (qmail 7979 invoked by uid 22791); 7 Mar 2011 14:47:00 -0000 X-SWARE-Spam-Status: No, hits=-0.6 required=5.0 tests=AWL,BAYES_05,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mtagate2.uk.ibm.com (HELO mtagate2.uk.ibm.com) (194.196.100.162) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 07 Mar 2011 14:46:55 +0000 Received: from d06nrmr1507.portsmouth.uk.ibm.com (d06nrmr1507.portsmouth.uk.ibm.com [9.149.38.233]) by mtagate2.uk.ibm.com (8.13.1/8.13.1) with ESMTP id p27EkkZD021833 for ; Mon, 7 Mar 2011 14:46:46 GMT Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by d06nrmr1507.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p27Ekxpu1454332 for ; Mon, 7 Mar 2011 14:46:59 GMT Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p27Ekjae001909 for ; Mon, 7 Mar 2011 07:46:45 -0700 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with SMTP id p27Ekib1001894; Mon, 7 Mar 2011 07:46:44 -0700 Message-Id: <201103071446.p27Ekib1001894@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 07 Mar 2011 15:46:44 +0100 Subject: Re: [patch, arm] Use cached dsc->is_thumb instead of re-computing To: yao@codesourcery.com (Yao Qi) Date: Mon, 07 Mar 2011 15:50:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <4D749DD9.8080703@codesourcery.com> from "Yao Qi" at Mar 07, 2011 04:56:57 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00459.txt.bz2 Yao Qi wrote: > gdb/ > * arm-tdep.c (displaced_read_reg): Add `dsc' parameter, remove `from' > parameter. Use cached result instead of calling displaced_in_arm_mode > again. > (branch_write_pc, alu_write_pc, load_write_pc): Add `dsc' parameter. > (displaced_write_reg, copy_preload, copy_preload_reg): Callers update. > (cleanup_copro_load_store, copy_copro_load_store): Likewise. > (cleanup_branch, copy_bx_blx_reg, copy_alu_imm): Likewise. > (cleanup_alu_reg, copy_alu_reg, cleanup_alu_shifted_reg): Likewise. > (copy_alu_shifted_reg, cleanup_load, cleanup_store): Likewise. > (copy_extra_ld_st, copy_ldr_str_ldrb_strb): Likewise. > (cleanup_block_load_all, cleanup_block_store_pc): Likewise. > (cleanup_block_load_pc, copy_block_xfer): Likewise. > * arm-linux-tdep.c (arm_linux_copy_svc): Callers update. > (arm_catch_kernel_helper_return): Likewise. > * gdb/arm-tdep.h : Update function declarations. There's a now-unused local variable "from" in arm_linux_copy_svc (you removed those nearly everywhere, but apparently missed this one), and the recently- added prototype declaration for displaced_read_reg is now unneeded again. If you could remove those two as well, the patch is OK. Thanks, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com