From: Joel Brobecker <brobecker@adacore.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 16/18] Add tdep files for x86 and powerpc.
Date: Fri, 25 Feb 2011 08:29:00 -0000 [thread overview]
Message-ID: <20110225034626.GD2495@adacore.com> (raw)
In-Reply-To: <201102241856.p1OIugJQ004697@glazunov.sibelius.xs4all.nl>
> The i386 bits have my blessing. The powerpc bits look a bit weird though:
Thanks for the review :).
> This bit of code looks like it is trying to support both stacks
> growing up and stack growing down. Does that really happen on
> VxWorks? Your code doesn't call set_gdbarch_inner_than(), so at least
> one of these branches must be dead code.
You are right to be puzzled by this code.
This code is actually a copy of a function that, as luck has it,
you removed a while ago because it was no longer used. It was
called something like generic_push_dummy_code. At the time,
I just copied the old function over.
In any case, I don't believe that I can have both direction on
powerpc-vxworks either, so I will clean it up.
--
Joel
next prev parent reply other threads:[~2011-02-25 3:46 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-24 17:49 Add support for VxWorks 5.x, 6.x and 653 Joel Brobecker
2011-02-24 17:49 ` [PATCH 01/18] Some ada-lang/ada-tasks routines needed by the VxWorks target Joel Brobecker
2011-02-24 17:50 ` [PATCH 04/18] add new "unload" command (symetry of existing "load" command) Joel Brobecker
2011-02-24 19:22 ` Eli Zaretskii
2011-02-24 17:50 ` [PATCH 03/18] New general purpose routines in utils.c Joel Brobecker
2011-02-24 19:06 ` Tom Tromey
2011-02-24 17:50 ` [PATCH 02/18] New command_post observer Joel Brobecker
2011-02-24 18:58 ` Tom Tromey
2011-02-24 17:51 ` [PATCH 05/18] new struct bp_target_info target_private_data field Joel Brobecker
2011-02-24 17:54 ` [PATCH 06/18] New module remote-wtx-utils Joel Brobecker
2011-02-24 19:26 ` Tom Tromey
2011-02-24 17:54 ` [PATCH 09/18] VxWorks breakpoint-handling module Joel Brobecker
2011-02-24 17:54 ` [PATCH 08/18] Add options to control Vxworks related settings Joel Brobecker
2011-02-24 17:55 ` [PATCH 10/18] "multi-tasks-mode" support Joel Brobecker
2011-02-24 17:56 ` [PATCH 11/18] Add partition support Joel Brobecker
2011-02-25 16:17 ` Tom Tromey
2011-02-24 17:56 ` [PATCH 07/18] remote-wtxapi: The WTX API abstraction layer Joel Brobecker
2011-02-24 19:44 ` Tom Tromey
2011-02-24 17:57 ` [PATCH 13/18] Add new "wtx" target Joel Brobecker
2011-02-25 16:15 ` Tom Tromey
2011-02-25 17:38 ` Joel Brobecker
2011-02-24 17:57 ` [PATCH 14/18] WTX-TCL support module Joel Brobecker
2011-02-25 15:59 ` Tom Tromey
2011-02-25 18:58 ` Joel Brobecker
2011-02-28 15:37 ` Tom Tromey
2011-02-24 17:57 ` [PATCH 12/18] remote-wtx-hw: register fetch/store support Joel Brobecker
2011-02-24 17:58 ` [PATCH 15/18] Add support for VxWorks 6 Joel Brobecker
2011-02-24 17:59 ` [PATCH 17/18] Configury and Makefile updates for VxWorks Joel Brobecker
2011-02-24 17:59 ` [PATCH 16/18] Add tdep files for x86 and powerpc Joel Brobecker
2011-02-24 18:58 ` Mark Kettenis
2011-02-25 8:29 ` Joel Brobecker [this message]
2011-02-24 18:04 ` [PATCH 18/18] document the new VxWorks port Joel Brobecker
2011-02-24 20:27 ` Eli Zaretskii
2011-02-25 11:12 ` Jerome Guitton
2011-02-25 11:27 ` Eli Zaretskii
2011-02-25 11:38 ` Jerome Guitton
2011-02-25 11:38 ` Joel Brobecker
2011-02-25 12:08 ` Eli Zaretskii
2011-02-25 13:26 ` Jerome Guitton
2011-02-25 11:44 ` Eli Zaretskii
2011-02-25 11:49 ` Joel Brobecker
2011-02-25 11:55 ` Jerome Guitton
2011-02-25 11:56 ` Joel Brobecker
2011-02-25 12:01 ` Pedro Alves
2011-02-25 14:21 ` Joel Brobecker
2011-02-25 14:44 ` Pedro Alves
2011-02-25 15:15 ` Joel Brobecker
2011-02-25 12:05 ` Jerome Guitton
2011-02-25 12:15 ` Eli Zaretskii
2011-02-25 12:56 ` Joel Brobecker
2011-02-25 13:20 ` Eli Zaretskii
2011-02-25 14:11 ` Jerome Guitton
2011-03-03 12:16 ` Joel Brobecker
2011-03-03 13:44 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110225034626.GD2495@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox