From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23322 invoked by alias); 25 Feb 2011 03:46:42 -0000 Received: (qmail 23311 invoked by uid 22791); 25 Feb 2011 03:46:41 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 25 Feb 2011 03:46:34 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 3846D2BADA9; Thu, 24 Feb 2011 22:46:33 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id uQrgoRfovm4P; Thu, 24 Feb 2011 22:46:33 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id B0E8B2BAD4B; Thu, 24 Feb 2011 22:46:32 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 3A192145A56; Fri, 25 Feb 2011 07:46:26 +0400 (RET) Date: Fri, 25 Feb 2011 08:29:00 -0000 From: Joel Brobecker To: Mark Kettenis Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 16/18] Add tdep files for x86 and powerpc. Message-ID: <20110225034626.GD2495@adacore.com> References: <1298569763-18784-1-git-send-email-brobecker@adacore.com> <1298569763-18784-17-git-send-email-brobecker@adacore.com> <201102241856.p1OIugJQ004697@glazunov.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201102241856.p1OIugJQ004697@glazunov.sibelius.xs4all.nl> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00742.txt.bz2 > The i386 bits have my blessing. The powerpc bits look a bit weird though: Thanks for the review :). > This bit of code looks like it is trying to support both stacks > growing up and stack growing down. Does that really happen on > VxWorks? Your code doesn't call set_gdbarch_inner_than(), so at least > one of these branches must be dead code. You are right to be puzzled by this code. This code is actually a copy of a function that, as luck has it, you removed a while ago because it was no longer used. It was called something like generic_push_dummy_code. At the time, I just copied the old function over. In any case, I don't believe that I can have both direction on powerpc-vxworks either, so I will clean it up. -- Joel