Re: [rfc, testsuite] Standardize tests for HW watchpoint capabilities

["Ulrich Weigand" <uweigand@de.ibm.com>]

Joel Brobecker wrote:
> > To fix these problems, I've added a couple of new skip_..._tests
> > procedures to lib/gdb.exp, and have updated all related test cases
> > to make use of those procedures instead of open-coding checks.
> 
> Generally speaking, I think this is the way to go (that's what we do
> in AdaCore's testsuite infrastructure [which does not use dejagnu]).
> 
> > The new procedures allow checking for:
> > 
> >  - skip_hw_breakpoint_tests: Guards tests of hardware breakpoints
> >  - skip_hw_watchpoint_tests: Guards tests of hardware watchpoints
> >  - skip_hw_watchpoint_multi_tests: Guards tests that require more
> >    than one hardware watchpoint to be active at the same time
> >  - skip_hw_watchpoint_access_tests: Guards tests that require
> >    read or access type hardware watchpoints
> [...]
> > Any comments?  I'm planning to commit this in a couple of days ...
> 
> I only skimmed the actual changes, and while spending a little more
> time checking the implementation of the routines above.  It looks
> fine to me. Nice improvement, IMO - thanks!

Thanks for the review!

I've checked this in now.

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com