From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 501 invoked by alias); 21 Feb 2011 15:07:02 -0000 Received: (qmail 305 invoked by uid 22791); 21 Feb 2011 15:07:01 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mtagate5.uk.ibm.com (HELO mtagate5.uk.ibm.com) (194.196.100.165) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 21 Feb 2011 15:06:56 +0000 Received: from d06nrmr1307.portsmouth.uk.ibm.com (d06nrmr1307.portsmouth.uk.ibm.com [9.149.38.129]) by mtagate5.uk.ibm.com (8.13.1/8.13.1) with ESMTP id p1LF6rki031283 for ; Mon, 21 Feb 2011 15:06:53 GMT Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by d06nrmr1307.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p1LF71JV647418 for ; Mon, 21 Feb 2011 15:07:01 GMT Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p1LF6qI5028844 for ; Mon, 21 Feb 2011 08:06:52 -0700 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with SMTP id p1LF6pDE028834; Mon, 21 Feb 2011 08:06:51 -0700 Message-Id: <201102211506.p1LF6pDE028834@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 21 Feb 2011 16:06:51 +0100 Subject: Re: [rfc, testsuite] Standardize tests for HW watchpoint capabilities To: brobecker@adacore.com (Joel Brobecker) Date: Mon, 21 Feb 2011 15:07:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <20110217101834.GE15527@adacore.com> from "Joel Brobecker" at Feb 17, 2011 02:18:34 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00546.txt.bz2 Joel Brobecker wrote: > > To fix these problems, I've added a couple of new skip_..._tests > > procedures to lib/gdb.exp, and have updated all related test cases > > to make use of those procedures instead of open-coding checks. > > Generally speaking, I think this is the way to go (that's what we do > in AdaCore's testsuite infrastructure [which does not use dejagnu]). > > > The new procedures allow checking for: > > > > - skip_hw_breakpoint_tests: Guards tests of hardware breakpoints > > - skip_hw_watchpoint_tests: Guards tests of hardware watchpoints > > - skip_hw_watchpoint_multi_tests: Guards tests that require more > > than one hardware watchpoint to be active at the same time > > - skip_hw_watchpoint_access_tests: Guards tests that require > > read or access type hardware watchpoints > [...] > > Any comments? I'm planning to commit this in a couple of days ... > > I only skimmed the actual changes, and while spending a little more > time checking the implementation of the routines above. It looks > fine to me. Nice improvement, IMO - thanks! Thanks for the review! I've checked this in now. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com