From: Joel Brobecker <brobecker@adacore.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [rfc, testsuite] Standardize tests for HW watchpoint capabilities
Date: Thu, 17 Feb 2011 11:41:00 -0000 [thread overview]
Message-ID: <20110217101834.GE15527@adacore.com> (raw)
In-Reply-To: <201102170953.p1H9rxCI010550@d06av02.portsmouth.uk.ibm.com>
> To fix these problems, I've added a couple of new skip_..._tests
> procedures to lib/gdb.exp, and have updated all related test cases
> to make use of those procedures instead of open-coding checks.
Generally speaking, I think this is the way to go (that's what we do
in AdaCore's testsuite infrastructure [which does not use dejagnu]).
> The new procedures allow checking for:
>
> - skip_hw_breakpoint_tests: Guards tests of hardware breakpoints
> - skip_hw_watchpoint_tests: Guards tests of hardware watchpoints
> - skip_hw_watchpoint_multi_tests: Guards tests that require more
> than one hardware watchpoint to be active at the same time
> - skip_hw_watchpoint_access_tests: Guards tests that require
> read or access type hardware watchpoints
[...]
> Any comments? I'm planning to commit this in a couple of days ...
I only skimmed the actual changes, and while spending a little more
time checking the implementation of the routines above. It looks
fine to me. Nice improvement, IMO - thanks!
--
Joel
next prev parent reply other threads:[~2011-02-17 10:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-17 10:18 Ulrich Weigand
2011-02-17 11:41 ` Joel Brobecker [this message]
2011-02-21 15:07 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110217101834.GE15527@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox