From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31647 invoked by alias); 17 Feb 2011 10:18:54 -0000 Received: (qmail 31637 invoked by uid 22791); 17 Feb 2011 10:18:53 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 17 Feb 2011 10:18:41 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 278A22BAC99; Thu, 17 Feb 2011 05:18:40 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 7vbFSUXlbxc8; Thu, 17 Feb 2011 05:18:40 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id B42332BAC8C; Thu, 17 Feb 2011 05:18:39 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 482A214586B; Thu, 17 Feb 2011 14:18:34 +0400 (RET) Date: Thu, 17 Feb 2011 11:41:00 -0000 From: Joel Brobecker To: Ulrich Weigand Cc: gdb-patches@sourceware.org Subject: Re: [rfc, testsuite] Standardize tests for HW watchpoint capabilities Message-ID: <20110217101834.GE15527@adacore.com> References: <201102170953.p1H9rxCI010550@d06av02.portsmouth.uk.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201102170953.p1H9rxCI010550@d06av02.portsmouth.uk.ibm.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00417.txt.bz2 > To fix these problems, I've added a couple of new skip_..._tests > procedures to lib/gdb.exp, and have updated all related test cases > to make use of those procedures instead of open-coding checks. Generally speaking, I think this is the way to go (that's what we do in AdaCore's testsuite infrastructure [which does not use dejagnu]). > The new procedures allow checking for: > > - skip_hw_breakpoint_tests: Guards tests of hardware breakpoints > - skip_hw_watchpoint_tests: Guards tests of hardware watchpoints > - skip_hw_watchpoint_multi_tests: Guards tests that require more > than one hardware watchpoint to be active at the same time > - skip_hw_watchpoint_access_tests: Guards tests that require > read or access type hardware watchpoints [...] > Any comments? I'm planning to commit this in a couple of days ... I only skimmed the actual changes, and while spending a little more time checking the implementation of the routines above. It looks fine to me. Nice improvement, IMO - thanks! -- Joel