Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [unavailable values part 1, 06/17] array element repeats, <unavailable> confused with 0.
Date: Wed, 16 Feb 2011 09:49:00 -0000	[thread overview]
Message-ID: <20110216092850.GA5399@host1.dyn.jankratochvil.net> (raw)
In-Reply-To: <201102151828.36004.pedro@codesourcery.com>

On Tue, 15 Feb 2011 19:28:35 +0100, Pedro Alves wrote:
> Indeed.  Could you double-check the patch below?

It seems correct to me now.


> -      if (memcmp (val1->contents + org_offset1 + prev_avail,
> -		  val2->contents + org_offset2 + prev_avail,
> -		  l2 - prev_avail) != 0)
> +      if (memcmp (val1->contents + offset1, val2->contents + offset2, l1) != 0)

[nitpick] GNU Coding standards says 78 columns (this is 79), OTOH Joel said he
already uses 80.  http://sourceware.org/ml/gdb-patches/2011-01/msg00255.html


Thanks,
Jan


  reply	other threads:[~2011-02-16  9:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-07 14:31 Pedro Alves
2011-02-14 12:00 ` Jan Kratochvil
2011-02-15 18:34   ` Pedro Alves
2011-02-16  9:49     ` Jan Kratochvil [this message]
2011-02-16 10:23       ` Pedro Alves
2011-02-16 11:12         ` Jan Kratochvil
2011-02-16 18:26           ` Michael Snyder
2011-02-16 19:46             ` Eli Zaretskii
2011-02-16 19:55               ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110216092850.GA5399@host1.dyn.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox