From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8004 invoked by alias); 16 Feb 2011 09:29:06 -0000 Received: (qmail 7996 invoked by uid 22791); 16 Feb 2011 09:29:05 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 16 Feb 2011 09:29:01 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p1G9Sr9j021778 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 16 Feb 2011 04:28:53 -0500 Received: from host1.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p1G9SpBn001186 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 16 Feb 2011 04:28:53 -0500 Received: from host1.dyn.jankratochvil.net (localhost [127.0.0.1]) by host1.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p1G9SpJU006834; Wed, 16 Feb 2011 10:28:51 +0100 Received: (from jkratoch@localhost) by host1.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id p1G9SoYR006822; Wed, 16 Feb 2011 10:28:50 +0100 Date: Wed, 16 Feb 2011 09:49:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [unavailable values part 1, 06/17] array element repeats, confused with 0. Message-ID: <20110216092850.GA5399@host1.dyn.jankratochvil.net> References: <201102071430.49735.pedro@codesourcery.com> <20110214120015.GF2454@host1.dyn.jankratochvil.net> <201102151828.36004.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201102151828.36004.pedro@codesourcery.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00355.txt.bz2 On Tue, 15 Feb 2011 19:28:35 +0100, Pedro Alves wrote: > Indeed. Could you double-check the patch below? It seems correct to me now. > - if (memcmp (val1->contents + org_offset1 + prev_avail, > - val2->contents + org_offset2 + prev_avail, > - l2 - prev_avail) != 0) > + if (memcmp (val1->contents + offset1, val2->contents + offset2, l1) != 0) [nitpick] GNU Coding standards says 78 columns (this is 79), OTOH Joel said he already uses 80. http://sourceware.org/ml/gdb-patches/2011-01/msg00255.html Thanks, Jan