Re: [PATCH, V850] Add support for V850E2 and V850E2V3

[Kevin Buettner <kevinb@redhat.com>]

On Wed, 12 Jan 2011 18:37:27 +0530
Rathish C <Rathish.C@kpitcummins.com> wrote:

> I have removed the definition from the sim-main.h file and 
> updated the patch accordingly.

Thanks for making this change.

> Please review the patch and let me know if there should be 
> any other modifications in it. 

Your most recent patch looks reasonable to me.

The gdb patch is still approved.

I've reviewed sim/MAINTAINERS and it appears that I may approve
patches for certain areas of the sim too.  Therefore, I approve
your sim changes as well.

I found a few nits, however, in your ChangeLog entry...

> 2011-01-12  Rathish.C  <rathish.c@kpitcummins.com>
> 	
> 	* gdb/v850-tdep.c: Add the enum values for mpu and fpu registers

Add a period (.) to the end of the above sentence.

> 	(v850_register_name): Add the mpu and fpu register names.
> 	(v850e_register_name): Add the mpu and fpu register names.
> 	(v850e2_register_name): New function.
> 	(v850_gdbarch_init): Add case for bfd_mach_v850e2 and 
> 	bfd_mach_v850e2v3.
> 	* sim/common/sim-trace.c: Update the function prototype of 
> 	save_data_size.
> 	Move the enum data_fmt from here

Add an ellipsis (...) after "here".

> 	* sim/common/sim-trace.h: to here.
> 	Add function prototype of save_data

Add a period to the end of the above sentence.

> 	* sim/v850/sim-main.h: Update the struct _v850_regs to include
> 	mpu and fpu system registers.
> 	Define the macros to access the mpu and fpu system registers.
> 	(SEXT3): Define.
> 	(TRACE_FP_INPUT_FPU1, TRACE_FP_INPUT_FPU2,
> 	TRACE_FP_INPUT_FPU3): Define.
> 	(TRACE_FP_INPUT_BOOL1_FPU2): Define.
> 	(TRACE_FP_INPUT_WORD2): Define.
> 	(TRACE_FP_RESULT_WORD1, TRACE_FP_RESULT_WORD2): Define.
> 	* sim/v850/simops.c: Update the function prototype of Add32

Add a period to the end of the above sentence.

> 	(update_fpsr): New function.
> 	(SignalException): New function.
> 	(SignalExceptionFPE): New function.
> 	(check_invalid_snan): New function.
> 	(v850_float_compare): New function.
> 	(v850_div): New function.
> 	(v850_divu): New function.
> 	(v850_sar): New function.
> 	(v850_shl): New function.
> 	(v850_shr): New function.
> 	(v850_satadd): New function.
> 	(v850_satsub): New function.
> 	(load_data_mem): New function.
> 	(store_data_mem): New function.
> 	(mpu_load_mem_test): New function.
> 	(mpu_store_mem_test): New function.
> 	* sim/v850/simops.h: Add function prototype for above
> 	mentioned functions.
> 	(check_cvt_fi, check_cvt_if, check_cvt_ff): Define.
> 	* sim/v850/v850-dc: Add entry for v850e2 and v850e2v3.
> 	* sim/v850/v850.igen: Add support for v850e2 and v850e2v3

Add a period to the end of the above sentence.

Kevin