Re: [PATCH, V850] Add support for V850E2 and V850E2V3

[Kevin Buettner <kevinb@redhat.com>]

Hi Rathish,

Thanks for making the changes that I requested.

Your changes to gdb/v850-tdep.c are approved.

I have one comment (see below) for the sim portion of the patch.  The
rest of the patch looks reasonable to me.  (It's unclear to me whether or
not I can approve sim patches...)

Kevin

On Fri, 10 Dec 2010 20:19:24 +0530
Rathish C <Rathish.C@kpitcummins.com> wrote:

> diff -upNr gdb-7.2.50-original/sim/v850/sim-main.h gdb-7.2.50-modified/sim/v850/sim-main.h
> --- gdb-7.2.50-original/sim/v850/sim-main.h	2002-11-30 23:31:30.000000000 +0530
> +++ gdb-7.2.50-modified/sim/v850/sim-main.h	2010-12-08 14:52:40.000000000 +0530
[...]
> @@ -61,6 +65,7 @@ struct sim_state {
>  #define STATE_CPU(sd,n) (&(sd)->cpu[n])
>  #else
>  #define STATE_CPU(sd,n) (&(sd)->cpu[0])
> +#define CPU (STATE_CPU (sd, 0))
>  #endif

Do you really need to define CPU here?  It appears to me that a
suitable definition for CPU is placed in support.h by igen at build
time.  If it turns out that you do need this definition, you should
make sure that the WITH_SMP case is handled too.