From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-76945-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 10294 invoked by alias); 13 Dec 2010 16:47:59 -0000
Received: (qmail 10285 invoked by uid 22791); 13 Dec 2010 16:47:58 -0000
X-SWARE-Spam-Status: No, hits=-6.8 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 13 Dec 2010 16:47:52 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oBDGlp5Q027715	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Mon, 13 Dec 2010 11:47:51 -0500
Received: from mesquite.lan ([10.3.113.8])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id oBDGloI1010534	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO)	for <gdb-patches@sourceware.org>; Mon, 13 Dec 2010 11:47:50 -0500
Date: Mon, 13 Dec 2010 16:47:00 -0000
From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH, V850] Add support for V850E2 and V850E2V3
Message-ID: <20101213094749.711396b0@mesquite.lan>
In-Reply-To: <371569CBCFB2E745B891DBB88B2DFDDD19E7B32E2D@KCINPUNHJCMS01.kpit.com>
References: <371569CBCFB2E745B891DBB88B2DFDDD19E7B32E2D@KCINPUNHJCMS01.kpit.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-12/txt/msg00190.txt.bz2

Hi Rathish,

Thanks for making the changes that I requested.

Your changes to gdb/v850-tdep.c are approved.

I have one comment (see below) for the sim portion of the patch.  The
rest of the patch looks reasonable to me.  (It's unclear to me whether or
not I can approve sim patches...)

Kevin

On Fri, 10 Dec 2010 20:19:24 +0530
Rathish C <Rathish.C@kpitcummins.com> wrote:

> diff -upNr gdb-7.2.50-original/sim/v850/sim-main.h gdb-7.2.50-modified/sim/v850/sim-main.h
> --- gdb-7.2.50-original/sim/v850/sim-main.h	2002-11-30 23:31:30.000000000 +0530
> +++ gdb-7.2.50-modified/sim/v850/sim-main.h	2010-12-08 14:52:40.000000000 +0530
[...]
> @@ -61,6 +65,7 @@ struct sim_state {
>  #define STATE_CPU(sd,n) (&(sd)->cpu[n])
>  #else
>  #define STATE_CPU(sd,n) (&(sd)->cpu[0])
> +#define CPU (STATE_CPU (sd, 0))
>  #endif

Do you really need to define CPU here?  It appears to me that a
suitable definition for CPU is placed in support.h by igen at build
time.  If it turns out that you do need this definition, you should
make sure that the WITH_SMP case is handled too.