From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6413 invoked by alias); 15 Jan 2011 00:57:01 -0000 Received: (qmail 6403 invoked by uid 22791); 15 Jan 2011 00:56:59 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 15 Jan 2011 00:56:51 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id p0F0uoPi025897 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 14 Jan 2011 19:56:50 -0500 Received: from mesquite.lan (ovpn-113-42.phx2.redhat.com [10.3.113.42]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p0F0un1H009267 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO) for ; Fri, 14 Jan 2011 19:56:49 -0500 Date: Sat, 15 Jan 2011 07:39:00 -0000 From: Kevin Buettner To: gdb-patches@sourceware.org Subject: Re: [PATCH, V850] Add support for V850E2 and V850E2V3 Message-ID: <20110114175649.256cba72@mesquite.lan> In-Reply-To: <371569CBCFB2E745B891DBB88B2DFDDD19EB425D6B@KCINPUNHJCMS01.kpit.com> References: <371569CBCFB2E745B891DBB88B2DFDDD19EB425D6B@KCINPUNHJCMS01.kpit.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00355.txt.bz2 On Wed, 12 Jan 2011 18:37:27 +0530 Rathish C wrote: > I have removed the definition from the sim-main.h file and > updated the patch accordingly. Thanks for making this change. > Please review the patch and let me know if there should be > any other modifications in it. Your most recent patch looks reasonable to me. The gdb patch is still approved. I've reviewed sim/MAINTAINERS and it appears that I may approve patches for certain areas of the sim too. Therefore, I approve your sim changes as well. I found a few nits, however, in your ChangeLog entry... > 2011-01-12 Rathish.C > > * gdb/v850-tdep.c: Add the enum values for mpu and fpu registers Add a period (.) to the end of the above sentence. > (v850_register_name): Add the mpu and fpu register names. > (v850e_register_name): Add the mpu and fpu register names. > (v850e2_register_name): New function. > (v850_gdbarch_init): Add case for bfd_mach_v850e2 and > bfd_mach_v850e2v3. > * sim/common/sim-trace.c: Update the function prototype of > save_data_size. > Move the enum data_fmt from here Add an ellipsis (...) after "here". > * sim/common/sim-trace.h: to here. > Add function prototype of save_data Add a period to the end of the above sentence. > * sim/v850/sim-main.h: Update the struct _v850_regs to include > mpu and fpu system registers. > Define the macros to access the mpu and fpu system registers. > (SEXT3): Define. > (TRACE_FP_INPUT_FPU1, TRACE_FP_INPUT_FPU2, > TRACE_FP_INPUT_FPU3): Define. > (TRACE_FP_INPUT_BOOL1_FPU2): Define. > (TRACE_FP_INPUT_WORD2): Define. > (TRACE_FP_RESULT_WORD1, TRACE_FP_RESULT_WORD2): Define. > * sim/v850/simops.c: Update the function prototype of Add32 Add a period to the end of the above sentence. > (update_fpsr): New function. > (SignalException): New function. > (SignalExceptionFPE): New function. > (check_invalid_snan): New function. > (v850_float_compare): New function. > (v850_div): New function. > (v850_divu): New function. > (v850_sar): New function. > (v850_shl): New function. > (v850_shr): New function. > (v850_satadd): New function. > (v850_satsub): New function. > (load_data_mem): New function. > (store_data_mem): New function. > (mpu_load_mem_test): New function. > (mpu_store_mem_test): New function. > * sim/v850/simops.h: Add function prototype for above > mentioned functions. > (check_cvt_fi, check_cvt_if, check_cvt_ff): Define. > * sim/v850/v850-dc: Add entry for v850e2 and v850e2v3. > * sim/v850/v850.igen: Add support for v850e2 and v850e2v3 Add a period to the end of the above sentence. Kevin