From: Joel Brobecker <brobecker@adacore.com>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC-v2] Fix hpux_major_release variable setting
Date: Fri, 14 Jan 2011 17:58:00 -0000 [thread overview]
Message-ID: <20110114170448.GS2504@adacore.com> (raw)
In-Reply-To: <000001cbb40b$b03b3020$10b19060$@muller@ics-cnrs.unistra.fr>
> 2011-01-14 Pierre Muller <muller@ics.u-strasbg.fr>
>
> * solib-som.h (hpux_major_release): Declare variable here.
> * solib-som.c: Remove <sys/utsname.h> header.
> (DEFAULT_HPUX_MAJOR_RELEASE): New macro.
> (hpux_major_release): Make global, change default value to
> DEFAULT_HPUX_MAJOR_RELEASE.
> (get_hpux_major_release): Simply return HPUX_MAJOR_RELEASE.
> * hppa-hpux-nat.c: Add <sys/utsname.h> include.
> Add "solib-som.h" header.
> (set_hpux_major_release): New function.
> (_initialize_hppa_hpux_nat): Call set_hpux_major_release.
I think that's OK, with one minor nit.
> + if (p)
> + hpux_major_release = atoi (p + 1);
> +}
> +
>
>
>
> /* Prevent warning from -Wmissing-prototypes. */
It's a lot of empty lines... While you commit the change, can you
reduce them to just one?
Thanks,
--
Joel
next prev parent reply other threads:[~2011-01-14 17:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-14 16:09 [RFC] " Pierre Muller
2011-01-14 16:32 ` Joel Brobecker
2011-01-14 16:59 ` [RFC-v2] " Pierre Muller
2011-01-14 17:58 ` Joel Brobecker [this message]
2011-01-14 18:17 ` Pedro Alves
2011-01-14 18:52 ` Pierre Muller
2011-01-14 18:54 ` Michael Snyder
2011-01-14 19:22 ` Paul Koning
2011-01-14 19:52 ` Joel Brobecker
2011-01-14 21:49 ` [RFA] remove form feeds Michael Snyder
2011-01-14 21:51 ` Tom Tromey
2011-01-14 21:54 ` Doug Evans
2011-01-14 22:31 ` Joel Brobecker
2011-01-14 23:55 ` Michael Snyder
2011-01-15 11:42 ` [RFC-v2] Fix hpux_major_release variable setting Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110114170448.GS2504@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox