From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2619 invoked by alias); 14 Jan 2011 17:04:56 -0000 Received: (qmail 2607 invoked by uid 22791); 14 Jan 2011 17:04:54 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 14 Jan 2011 17:04:50 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id D6D032BAC7F; Fri, 14 Jan 2011 12:04:48 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 3nORZsvwqz20; Fri, 14 Jan 2011 12:04:48 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C39C22BAC67; Fri, 14 Jan 2011 12:04:48 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 5B2BF1459AD; Fri, 14 Jan 2011 12:04:48 -0500 (EST) Date: Fri, 14 Jan 2011 17:58:00 -0000 From: Joel Brobecker To: Pierre Muller Cc: gdb-patches@sourceware.org Subject: Re: [RFC-v2] Fix hpux_major_release variable setting Message-ID: <20110114170448.GS2504@adacore.com> References: <000f01cbb401$1093cdc0$31bb6940$@muller@ics-cnrs.unistra.fr> <20110114163035.GQ2504@adacore.com> <000001cbb40b$b03b3020$10b19060$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <000001cbb40b$b03b3020$10b19060$@muller@ics-cnrs.unistra.fr> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00337.txt.bz2 > 2011-01-14 Pierre Muller > > * solib-som.h (hpux_major_release): Declare variable here. > * solib-som.c: Remove header. > (DEFAULT_HPUX_MAJOR_RELEASE): New macro. > (hpux_major_release): Make global, change default value to > DEFAULT_HPUX_MAJOR_RELEASE. > (get_hpux_major_release): Simply return HPUX_MAJOR_RELEASE. > * hppa-hpux-nat.c: Add include. > Add "solib-som.h" header. > (set_hpux_major_release): New function. > (_initialize_hppa_hpux_nat): Call set_hpux_major_release. I think that's OK, with one minor nit. > + if (p) > + hpux_major_release = atoi (p + 1); > +} > + > > > > /* Prevent warning from -Wmissing-prototypes. */ It's a lot of empty lines... While you commit the change, can you reduce them to just one? Thanks, -- Joel