From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: msnyder@vmware.com
Cc: pierre.muller@ics-cnrs.unistra.fr, pedro@codesourcery.com,
gdb-patches@sourceware.org, brobecker@adacore.com
Subject: Re: [RFC-v2] Fix hpux_major_release variable setting
Date: Sat, 15 Jan 2011 11:42:00 -0000 [thread overview]
Message-ID: <201101151123.p0FBNIxm031201@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <4D309B82.7070104@vmware.com> (message from Michael Snyder on Fri, 14 Jan 2011 10:52:50 -0800)
> Date: Fri, 14 Jan 2011 10:52:50 -0800
> From: Michael Snyder <msnyder@vmware.com>
>
> Pierre Muller wrote:
> > Thanks for the feedback to
> > Pedro and Joel.
> >
> > Committed with void added.
> >
> > Pierre
> >
> > PS: The nit by Joel was a problem when I sent the patch,
> > there are no 4 empty lines, but
> > there is a "^L" line, which got lost
> > by the way I sent the patch in.
>
> Does it make sense to remove these ^L characters?
> I doubt if anybody prints out these sources any more...
To me they serve as logical markers to seperate sections of code. I
believe the GNU coding standards already mention that they're meant
for that purpose only and not meant for printing source code at all.
Using them has always been a matter of taste; I don't see a good
reason for going through the code to eliminate them.
prev parent reply other threads:[~2011-01-15 11:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-14 16:09 [RFC] " Pierre Muller
2011-01-14 16:32 ` Joel Brobecker
2011-01-14 16:59 ` [RFC-v2] " Pierre Muller
2011-01-14 17:58 ` Joel Brobecker
2011-01-14 18:17 ` Pedro Alves
2011-01-14 18:52 ` Pierre Muller
2011-01-14 18:54 ` Michael Snyder
2011-01-14 19:22 ` Paul Koning
2011-01-14 19:52 ` Joel Brobecker
2011-01-14 21:49 ` [RFA] remove form feeds Michael Snyder
2011-01-14 21:51 ` Tom Tromey
2011-01-14 21:54 ` Doug Evans
2011-01-14 22:31 ` Joel Brobecker
2011-01-14 23:55 ` Michael Snyder
2011-01-15 11:42 ` Mark Kettenis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201101151123.p0FBNIxm031201@glazunov.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
--cc=pedro@codesourcery.com \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox