From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: msnyder@vmware.com
Cc: gdb-patches@sourceware.org, brobecker@adacore.com
Subject: Re: [RFA] Evening up the right margins
Date: Wed, 12 Jan 2011 21:58:00 -0000 [thread overview]
Message-ID: <201101122128.p0CLSE7q017580@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <4D2D1D4B.9070509@vmware.com> (message from Michael Snyder on Tue, 11 Jan 2011 19:17:31 -0800)
> Date: Tue, 11 Jan 2011 19:17:31 -0800
> From: Michael Snyder <msnyder@vmware.com>
>
> Mark and Joel, I'm especially interested in your feedback.
>
> This patch is meant to help even up the right margins without adding
> extra lines to the file. If folks approve, I'll do more.
The thought that comes to my mind is "if it ain't broke, don't fix
it". I think the benefit from these changes is marginal. Is this
really worth the extra churn in the repository? It does make diffing
revisions of the affected files more difficult...
So I'd say that making changes like this is fine if you're changing
the text of a comment or the code anyway, but otherwise I'd leave
things alone.
next prev parent reply other threads:[~2011-01-12 21:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-12 3:57 Michael Snyder
2011-01-12 14:59 ` Joel Brobecker
2011-01-12 21:58 ` Mark Kettenis [this message]
2011-01-12 22:10 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201101122128.p0CLSE7q017580@glazunov.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox