From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10759 invoked by alias); 12 Jan 2011 21:28:48 -0000 Received: (qmail 10751 invoked by uid 22791); 12 Jan 2011 21:28:48 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 12 Jan 2011 21:28:43 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id p0CLSGne007798; Wed, 12 Jan 2011 22:28:16 +0100 (CET) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id p0CLSE7q017580; Wed, 12 Jan 2011 22:28:15 +0100 (CET) Date: Wed, 12 Jan 2011 21:58:00 -0000 Message-Id: <201101122128.p0CLSE7q017580@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: msnyder@vmware.com CC: gdb-patches@sourceware.org, brobecker@adacore.com In-reply-to: <4D2D1D4B.9070509@vmware.com> (message from Michael Snyder on Tue, 11 Jan 2011 19:17:31 -0800) Subject: Re: [RFA] Evening up the right margins References: <4D2D1D4B.9070509@vmware.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00282.txt.bz2 > Date: Tue, 11 Jan 2011 19:17:31 -0800 > From: Michael Snyder > > Mark and Joel, I'm especially interested in your feedback. > > This patch is meant to help even up the right margins without adding > extra lines to the file. If folks approve, I'll do more. The thought that comes to my mind is "if it ain't broke, don't fix it". I think the benefit from these changes is marginal. Is this really worth the extra churn in the repository? It does make diffing revisions of the affected files more difficult... So I'd say that making changes like this is fine if you're changing the text of a comment or the code anyway, but otherwise I'd leave things alone.