Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
	Mark Kettenis <mark.kettenis@xs4all.nl>
Subject: Re: [RFA] Evening up the right margins
Date: Wed, 12 Jan 2011 14:59:00 -0000	[thread overview]
Message-ID: <20110112132527.GD2504@adacore.com> (raw)
In-Reply-To: <4D2D1D4B.9070509@vmware.com>

> Mark and Joel, I'm especially interested in your feedback.

I think some are bettter, and some are worse.  I agree that shortening
some of the lines seem to make the paragraph more visually pleasing,
and perhaps easier to read. However, I also think that it has made
some of the lines a little harder to read.  For instance:

+   The GNAT encoding used to describle the array index type evolved a
+   bit.  Initially, the information would be provided through the

Here, you split "a" from "bit".  I tend to avoid that.  This is not
a mandatory practice, and I learnt it many years ago when, I think,
I was reviewing the typographical practices recommended by the
"Bibliotheque de France".

My take on this is that changes that reduce the line length should be
made if you think that the result is easier to read/better, or if
it exceeds the 80 columns.  If we agree than 70 characters is the
guideline (I feel like argument for 74 to match the ChangeLog, but
let's not until we spend more time following the current 70), then
I think it's fine to leave things as is.

The following is a matter of taste, so just my preference:

> +        error (_("Fixed-point values must be "
> +		 "assigned to fixed-point variables"));

If you can fit the entire string on one line and still not exceed
the 80 characters limit, I personally prefer everything on the same line.
I suppose it will stick out a little, if we mostly follow the 70
characters guideline, but it's easier to read.  Not a strong opinion,
however.

Comments of the following format are not complient, however, and
should be fixed:

        /* Line 1
         * Line 2
         * Line 3
         */

I can take care of the ada-* part, but I'm going to be a little
busy over the next few days...

-- 
Joel


  reply	other threads:[~2011-01-12 13:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-12  3:57 Michael Snyder
2011-01-12 14:59 ` Joel Brobecker [this message]
2011-01-12 21:58 ` Mark Kettenis
2011-01-12 22:10   ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110112132527.GD2504@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=mark.kettenis@xs4all.nl \
    --cc=msnyder@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox