Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* New ARI warning Fri Jan  7 01:54:25 UTC 2011
@ 2011-01-07  1:54 GDB Administrator
  2011-01-07  2:18 ` Michael Snyder
  0 siblings, 1 reply; 3+ messages in thread
From: GDB Administrator @ 2011-01-07  1:54 UTC (permalink / raw)
  To: gdb-patches

622a623,624
> gdb/mi/mi-cmd-disas.c:131: gettext: _ markup: All messages should be marked up with _.
gdb/mi/mi-cmd-disas.c:131:    error ("mi_cmd_disassemble: Usage: ( [-f filename -l linenum [-n "
> gdb/mi/mi-cmd-disas.c:135: gettext: _ markup: All messages should be marked up with _.
gdb/mi/mi-cmd-disas.c:135:    error ("mi_cmd_disassemble: Usage: [-f filename -l "
1072d1073
< gdb/solib-irix.c:575: gettext: _ markup: All messages should be marked up with _.
gdb/solib-irix.c:575:	      warning ("current_sos: truncating name of "
1249d1249
< gdb/tui/tui-layout.c:487: code: OP eol: Do not use &&, or || at the end of a line
gdb/tui/tui-layout.c:487:		  if (TUI_DATA_WIN->detail.data_display_info.regs_display_type !=
1267a1268
> gdb/tui/tui-winsource.c:346: code: if assignment: An IF statement's expression contains an assignment (the GNU coding standard discourages this)
gdb/tui/tui-winsource.c:346:	  if ((offset = win_info->detail.source_info.horizontal_offset	       - num_to_scroll) < 0)
1321d1321
< gdb/varobj.c:2063: gettext: _ markup: All messages should be marked up with _.
gdb/varobj.c:2063:	      warning ("Assertion failed: Could not find "


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: New ARI warning Fri Jan  7 01:54:25 UTC 2011
  2011-01-07  1:54 New ARI warning Fri Jan 7 01:54:25 UTC 2011 GDB Administrator
@ 2011-01-07  2:18 ` Michael Snyder
  2011-01-07  4:14   ` Joel Brobecker
  0 siblings, 1 reply; 3+ messages in thread
From: Michael Snyder @ 2011-01-07  2:18 UTC (permalink / raw)
  To: gdb-patches

GDB Administrator wrote:
> 622a623,624
>> gdb/mi/mi-cmd-disas.c:131: gettext: _ markup: All messages should be marked up with _.
> gdb/mi/mi-cmd-disas.c:131:    error ("mi_cmd_disassemble: Usage: ( [-f filename -l linenum [-n "
>> gdb/mi/mi-cmd-disas.c:135: gettext: _ markup: All messages should be marked up with _.
> gdb/mi/mi-cmd-disas.c:135:    error ("mi_cmd_disassemble: Usage: [-f filename -l "
> 1072d1073
> < gdb/solib-irix.c:575: gettext: _ markup: All messages should be marked up with _.
> gdb/solib-irix.c:575:	      warning ("current_sos: truncating name of "
> 1249d1249
> < gdb/tui/tui-layout.c:487: code: OP eol: Do not use &&, or || at the end of a line
> gdb/tui/tui-layout.c:487:		  if (TUI_DATA_WIN->detail.data_display_info.regs_display_type !=
> 1267a1268
>> gdb/tui/tui-winsource.c:346: code: if assignment: An IF statement's expression contains an assignment (the GNU coding standard discourages this)
> gdb/tui/tui-winsource.c:346:	  if ((offset = win_info->detail.source_info.horizontal_offset	       - num_to_scroll) < 0)
> 1321d1321
> < gdb/varobj.c:2063: gettext: _ markup: All messages should be marked up with _.
> gdb/varobj.c:2063:	      warning ("Assertion failed: Could not find "


Hmmm, these are all files that I touched, but the issues are all
pre-existing.  What's going on?  Why the new warnings?



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: New ARI warning Fri Jan  7 01:54:25 UTC 2011
  2011-01-07  2:18 ` Michael Snyder
@ 2011-01-07  4:14   ` Joel Brobecker
  0 siblings, 0 replies; 3+ messages in thread
From: Joel Brobecker @ 2011-01-07  4:14 UTC (permalink / raw)
  To: Michael Snyder; +Cc: gdb-patches

> Hmmm, these are all files that I touched, but the issues are all
> pre-existing.  What's going on?  Why the new warnings?

Pierre can give more details, but the detection mechanism is fairly
simple-minded: It compares new reports against the previous report,
and if there are positive diffs, it sends it in case it is a new
warning.

It is worth fixing those, even if they were pre-existing, but it's
not a requirement.  I try to help (for instance, I did a few yesterday),
but my schedule until next Tue is going to be a bit packed...

-- 
Joel


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-01-07  4:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-07  1:54 New ARI warning Fri Jan 7 01:54:25 UTC 2011 GDB Administrator
2011-01-07  2:18 ` Michael Snyder
2011-01-07  4:14   ` Joel Brobecker

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox