Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Masaki Muranaka <monaka@monami-software.com>
To: Daniel Jacobowitz <drow@false.org>
Cc: Andreas Schwab <schwab@suse.de>, gdb-patches@sourceware.org
Subject: Re: [patch] Failed to build mips64-elf with NLS on OSX
Date: Fri, 16 Jun 2006 00:42:00 -0000	[thread overview]
Message-ID: <2010FC01-7CFF-4F4D-AC62-2F646ED43FD8@monami-software.com> (raw)
In-Reply-To: <20060615135139.GA17504@nevyn.them.org>

[-- Attachment #1: Type: text/plain, Size: 513 bytes --]


On 2006/06/15, at 22:51, Daniel Jacobowitz wrote:
> But it's right :-)
>
> char *libintl_gettext (const char *) __attribute__((format_arg(1)));
>
> That's enough to fix it.

Thanks for your comment.
It's shut up the warinings to add the attribute.

An attached file is the patch I was applied.
For MacOSX, it's enough to modify at libgnuintl.h:line 128.
And  I guess it should be applied line 119, too.

Then, what should I do to request for apply?
Need to post to gcc-bugs?

--
Masaki Muranaka
Monami software


[-- Attachment #2: libgnuintl.h.diff --]
[-- Type: application/octet-stream, Size: 1003 bytes --]

Index: libgnuintl.h
===================================================================
RCS file: /cvs/src/src/intl/libgnuintl.h,v
retrieving revision 1.1
diff -u -p -r1.1 libgnuintl.h
--- libgnuintl.h	22 May 2006 15:30:13 -0000	1.1
+++ libgnuintl.h	16 Jun 2006 00:40:02 -0000
@@ -116,7 +116,7 @@ extern "C" {
    LC_MESSAGES locale.  If not found, returns MSGID itself (the default
    text).  */
 #ifdef _INTL_REDIRECT_INLINE
-extern char *libintl_gettext (const char *__msgid);
+extern char *libintl_gettext (const char *__msgid)  __attribute__((format_arg(1)));
 static inline char *gettext (const char *__msgid)
 {
   return libintl_gettext (__msgid);
@@ -126,7 +126,7 @@ static inline char *gettext (const char 
 # define gettext libintl_gettext
 #endif
 extern char *gettext _INTL_PARAMS ((const char *__msgid))
-       _INTL_ASM (libintl_gettext);
+       _INTL_ASM (libintl_gettext)  __attribute__((format_arg(1)));
 #endif
 
 /* Look up MSGID in the DOMAINNAME message catalog for the current

      reply	other threads:[~2006-06-16  0:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-15  8:12 Masaki Muranaka
2006-06-15  8:22 ` Andreas Schwab
2006-06-15  9:12   ` Masaki Muranaka
2006-06-15  9:24     ` Andreas Schwab
2006-06-15 10:04       ` Masaki Muranaka
2006-06-15 11:34         ` Masaki Muranaka
2006-06-15 13:51           ` Daniel Jacobowitz
2006-06-16  0:42             ` Masaki Muranaka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2010FC01-7CFF-4F4D-AC62-2F646ED43FD8@monami-software.com \
    --to=monaka@monami-software.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox