From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24244 invoked by alias); 16 Jun 2006 00:42:44 -0000 Received: (qmail 24227 invoked by uid 22791); 16 Jun 2006 00:42:43 -0000 X-Spam-Check-By: sourceware.org Received: from p12018-ipbffx02marunouchi.tokyo.ocn.ne.jp (HELO mail.pizzafactory.jp) (222.147.75.18) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 16 Jun 2006 00:42:41 +0000 Received: from [192.168.0.2] (unknown [192.168.0.2]) by mail.pizzafactory.jp (Postfix) with ESMTP id DE8AD2054E47; Fri, 16 Jun 2006 09:42:38 +0900 (JST) In-Reply-To: <20060615135139.GA17504@nevyn.them.org> References: <9E9B2AC9-6DB7-4D6A-BF9C-2B3E387F67E2@monami-software.com> <6E68F226-6A7E-4DB7-8734-A448045A6129@monami-software.com> <9B7B5DA2-2CC0-49E7-BE07-403B942D11CD@monami-software.com> <20060615135139.GA17504@nevyn.them.org> Mime-Version: 1.0 (Apple Message framework v750) Content-Type: multipart/mixed; boundary=Apple-Mail-5-312664540 Message-Id: <2010FC01-7CFF-4F4D-AC62-2F646ED43FD8@monami-software.com> Cc: Andreas Schwab , gdb-patches@sourceware.org From: Masaki Muranaka Subject: Re: [patch] Failed to build mips64-elf with NLS on OSX Date: Fri, 16 Jun 2006 00:42:00 -0000 To: Daniel Jacobowitz X-Mailer: Apple Mail (2.750) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-06/txt/msg00233.txt.bz2 --Apple-Mail-5-312664540 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed Content-length: 513 On 2006/06/15, at 22:51, Daniel Jacobowitz wrote: > But it's right :-) > > char *libintl_gettext (const char *) __attribute__((format_arg(1))); > > That's enough to fix it. Thanks for your comment. It's shut up the warinings to add the attribute. An attached file is the patch I was applied. For MacOSX, it's enough to modify at libgnuintl.h:line 128. And I guess it should be applied line 119, too. Then, what should I do to request for apply? Need to post to gcc-bugs? -- Masaki Muranaka Monami software --Apple-Mail-5-312664540 Content-Transfer-Encoding: 7bit Content-Type: application/octet-stream; x-unix-mode=0644; name="libgnuintl.h.diff" Content-Disposition: attachment; filename=libgnuintl.h.diff Content-length: 1003 Index: libgnuintl.h =================================================================== RCS file: /cvs/src/src/intl/libgnuintl.h,v retrieving revision 1.1 diff -u -p -r1.1 libgnuintl.h --- libgnuintl.h 22 May 2006 15:30:13 -0000 1.1 +++ libgnuintl.h 16 Jun 2006 00:40:02 -0000 @@ -116,7 +116,7 @@ extern "C" { LC_MESSAGES locale. If not found, returns MSGID itself (the default text). */ #ifdef _INTL_REDIRECT_INLINE -extern char *libintl_gettext (const char *__msgid); +extern char *libintl_gettext (const char *__msgid) __attribute__((format_arg(1))); static inline char *gettext (const char *__msgid) { return libintl_gettext (__msgid); @@ -126,7 +126,7 @@ static inline char *gettext (const char # define gettext libintl_gettext #endif extern char *gettext _INTL_PARAMS ((const char *__msgid)) - _INTL_ASM (libintl_gettext); + _INTL_ASM (libintl_gettext) __attribute__((format_arg(1))); #endif /* Look up MSGID in the DOMAINNAME message catalog for the current --Apple-Mail-5-312664540--