Re: [patch] Failed to build mips64-elf with NLS on OSX

Masaki Muranaka
2006-06-16T00:42:44Z

[-- Attachment #1: Type: text/plain, Size: 513 bytes --]

On 2006/06/15, at 22:51, Daniel Jacobowitz wrote:
> But it's right :-)
>
> char *libintl_gettext (const char *) __attribute__((format_arg(1)));
>
> That's enough to fix it.

Thanks for your comment.
It's shut up the warinings to add the attribute.

An attached file is the patch I was applied.
For MacOSX, it's enough to modify at libgnuintl.h:line 128.
And I guess it should be applied line 119, too.

Then, what should I do to request for apply?
Need to post to gcc-bugs?

--
Masaki Muranaka
Monami software

[-- Attachment #2: libgnuintl.h.diff --]
[-- Type: application/octet-stream, Size: 1003 bytes --]

Index: libgnuintl.h
===================================================================
RCS file: /cvs/src/src/intl/libgnuintl.h,v
retrieving revision 1.1
diff -u -p -r1.1 libgnuintl.h
--- libgnuintl.h 22 May 2006 15:30:13 -0000 1.1
+++ libgnuintl.h 16 Jun 2006 00:40:02 -0000
@@ -116,7 +116,7 @@ extern "C" {
LC_MESSAGES locale. If not found, returns MSGID itself (the default
text). */
#ifdef _INTL_REDIRECT_INLINE
-extern char *libintl_gettext (const char *__msgid);
+extern char *libintl_gettext (const char *__msgid) __attribute__((format_arg(1)));
static inline char *gettext (const char *__msgid)
{
return libintl_gettext (__msgid);
@@ -126,7 +126,7 @@ static inline char *gettext (const char
# define gettext libintl_gettext
#endif
extern char *gettext _INTL_PARAMS ((const char *__msgid))
- _INTL_ASM (libintl_gettext);
+ _INTL_ASM (libintl_gettext) __attribute__((format_arg(1)));
#endif

/* Look up MSGID in the DOMAINNAME message catalog for the current