Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: pierre.muller@ics-cnrs.unistra.fr, gdb-patches@sourceware.org
Subject: Re: [RFC] Improve amd64 prologue analysis
Date: Thu, 16 Dec 2010 04:15:00 -0000	[thread overview]
Message-ID: <20101216041530.GC2596@adacore.com> (raw)
In-Reply-To: <201012152306.oBFN6x6N019463@glazunov.sibelius.xs4all.nl>

> I hope you'll understand my reluctance to add one after managing 7
> years or so without.

OK - that's very reasonable. Prologue analyzers are very ugly, and
the amd64 one is worse, because the insns are harder to parse
(at least to me).  That's why, until Pierre started sending patches,
I never really considered submitting the changes we made, thinking
that we were the only one for whom it actually made a difference.

> So if support for pdata/xdata gets added I would expect that
> the prologue analyzer won't be needed on 64-bit Windows either.

That's correct.

> If you stick it somewhere where I don't need to look at it, I won't
> care as much.

Sounds like an acceptable compromise.

-- 
Joel


  reply	other threads:[~2010-12-16  4:15 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-15 17:28 Pierre Muller
2010-11-18 17:22 ` Joel Brobecker
2010-11-19  8:15   ` Pierre Muller
2010-11-19 17:20     ` Joel Brobecker
2010-11-19 22:50       ` Pierre Muller
2010-12-14  7:05         ` Joel Brobecker
2010-12-14  9:58           ` Pedro Alves
2010-12-15 23:07           ` Mark Kettenis
2010-12-16  4:15             ` Joel Brobecker [this message]
2010-11-24 21:19     ` Mark Kettenis
2010-11-24 22:15       ` Joel Brobecker
2010-11-24 22:26         ` Joel Brobecker
2010-11-25 13:39           ` Mark Kettenis
2010-11-25 16:30             ` Joel Brobecker
2010-11-25 19:19               ` Kai Tietz
2010-11-24 22:17       ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101216041530.GC2596@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=mark.kettenis@xs4all.nl \
    --cc=pierre.muller@ics-cnrs.unistra.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox