From: Joel Brobecker <brobecker@adacore.com>
To: kettenis@gnu.org
Cc: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>,
gdb-patches@sourceware.org
Subject: Re: [RFC] Improve amd64 prologue analysis
Date: Tue, 14 Dec 2010 07:05:00 -0000 [thread overview]
Message-ID: <20101214070535.GO2596@adacore.com> (raw)
In-Reply-To: <000901cb883c$067a8860$136f9920$@muller@ics-cnrs.unistra.fr>
Hi Mark,
> I think that your code does indeed catch some
> instructions that are not covered by my patch,
> especially in Windows DLL.
If Pierre were to submit a patch that merges both our changes,
do you think it would have a chance of being included?
The alternative is to start working on a pdata/xdata unwinder,
but I don't see myself having the time to look into that anytime
soon (not within the next 12 months).
You mentioned that, if we have prologue instruction parsers, they should
be Windows-specific. But I would think that this extra level of
precaution is unnecessary, since the prologue analyzer should almost
never be used on the other platforms where we have the DWARF frame info.
Is that wishful thinking?
--
Joel
next prev parent reply other threads:[~2010-12-14 7:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-15 17:28 Pierre Muller
2010-11-18 17:22 ` Joel Brobecker
2010-11-19 8:15 ` Pierre Muller
2010-11-19 17:20 ` Joel Brobecker
2010-11-19 22:50 ` Pierre Muller
2010-12-14 7:05 ` Joel Brobecker [this message]
2010-12-14 9:58 ` Pedro Alves
2010-12-15 23:07 ` Mark Kettenis
2010-12-16 4:15 ` Joel Brobecker
2010-11-24 21:19 ` Mark Kettenis
2010-11-24 22:15 ` Joel Brobecker
2010-11-24 22:26 ` Joel Brobecker
2010-11-25 13:39 ` Mark Kettenis
2010-11-25 16:30 ` Joel Brobecker
2010-11-25 19:19 ` Kai Tietz
2010-11-24 22:17 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101214070535.GO2596@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=kettenis@gnu.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox