From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18871 invoked by alias); 16 Dec 2010 04:15:56 -0000 Received: (qmail 18859 invoked by uid 22791); 16 Dec 2010 04:15:53 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 16 Dec 2010 04:15:47 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id F41122BAB43; Wed, 15 Dec 2010 23:15:45 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id M5Y6Ks6CRvae; Wed, 15 Dec 2010 23:15:45 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 849CE2BAB42; Wed, 15 Dec 2010 23:15:45 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 9DC66145B58; Thu, 16 Dec 2010 05:15:30 +0100 (CET) Date: Thu, 16 Dec 2010 04:15:00 -0000 From: Joel Brobecker To: Mark Kettenis Cc: pierre.muller@ics-cnrs.unistra.fr, gdb-patches@sourceware.org Subject: Re: [RFC] Improve amd64 prologue analysis Message-ID: <20101216041530.GC2596@adacore.com> References: <001701cb84ea$6883c170$398b4450$@muller@ics-cnrs.unistra.fr> <20101118172209.GE2634@adacore.com> <004201cb87c1$dab95cd0$902c1670$@muller@ics-cnrs.unistra.fr> <20101119172011.GI2634@adacore.com> <000901cb883c$067a8860$136f9920$@muller@ics-cnrs.unistra.fr> <20101214070535.GO2596@adacore.com> <201012152306.oBFN6x6N019463@glazunov.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201012152306.oBFN6x6N019463@glazunov.sibelius.xs4all.nl> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00330.txt.bz2 > I hope you'll understand my reluctance to add one after managing 7 > years or so without. OK - that's very reasonable. Prologue analyzers are very ugly, and the amd64 one is worse, because the insns are harder to parse (at least to me). That's why, until Pierre started sending patches, I never really considered submitting the changes we made, thinking that we were the only one for whom it actually made a difference. > So if support for pdata/xdata gets added I would expect that > the prologue analyzer won't be needed on 64-bit Windows either. That's correct. > If you stick it somewhere where I don't need to look at it, I won't > care as much. Sounds like an acceptable compromise. -- Joel