From: Pedro Alves <pedro@codesourcery.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org, Tom Tromey <tromey@redhat.com>
Subject: Re: [RFA/Python] Fix procfs.c build failure on 32bit solaris (_FILE_OFFSET_BITS)
Date: Thu, 25 Nov 2010 13:12:00 -0000 [thread overview]
Message-ID: <201011251311.58138.pedro@codesourcery.com> (raw)
In-Reply-To: <20101124172002.GZ2634@adacore.com>
On Wednesday 24 November 2010 17:20:02, Joel Brobecker wrote:
> > 2010-11-23 Pedro Alves <pedro@codesourcery.com>
> >
> > gdb/
> > * breakpoint.h: No longer include python.h or python-internal.h.
> > (struct breakpoint_object): Forward declare.
> > * defs.h (PyObject) [!HAVE_PYTHON]: Don't define.
> > * varobj.c (PyObject) [!HAVE_PYTHON]: Define.
> > * python/py-breakpoint.c (build_bp_list): Cast py_bp_object to
> > PyObject pointer.
> > (gdbpy_breakpoint_created): Remove casts around py_bp_object
> > accesses.
>
> Thanks, Pedro! I confirm that this fixes the problem.
> Can we check it in? (review needed?)
Thanks for confirming. I've checked it in now.
--
Pedro Alves
next prev parent reply other threads:[~2010-11-25 13:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-23 1:14 Joel Brobecker
2010-11-23 3:25 ` Jan Kratochvil
2010-11-23 12:42 ` Pedro Alves
2010-11-23 15:22 ` Tom Tromey
2010-11-23 16:29 ` Pedro Alves
2010-11-23 17:23 ` Phil Muldoon
2010-11-23 17:47 ` Pedro Alves
2010-11-24 17:20 ` Joel Brobecker
2010-11-25 13:12 ` Pedro Alves [this message]
2010-11-24 18:25 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201011251311.58138.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox