From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21313 invoked by alias); 25 Nov 2010 13:12:12 -0000 Received: (qmail 21289 invoked by uid 22791); 25 Nov 2010 13:12:11 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 25 Nov 2010 13:12:03 +0000 Received: (qmail 31577 invoked from network); 25 Nov 2010 13:12:01 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 25 Nov 2010 13:12:01 -0000 From: Pedro Alves To: Joel Brobecker Subject: Re: [RFA/Python] Fix procfs.c build failure on 32bit solaris (_FILE_OFFSET_BITS) Date: Thu, 25 Nov 2010 13:12:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.33-29-realtime; KDE/4.4.5; x86_64; ; ) Cc: gdb-patches@sourceware.org, Tom Tromey References: <1290474834-1945-1-git-send-email-brobecker@adacore.com> <201011231628.33851.pedro@codesourcery.com> <20101124172002.GZ2634@adacore.com> In-Reply-To: <20101124172002.GZ2634@adacore.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201011251311.58138.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00426.txt.bz2 On Wednesday 24 November 2010 17:20:02, Joel Brobecker wrote: > > 2010-11-23 Pedro Alves > > > > gdb/ > > * breakpoint.h: No longer include python.h or python-internal.h. > > (struct breakpoint_object): Forward declare. > > * defs.h (PyObject) [!HAVE_PYTHON]: Don't define. > > * varobj.c (PyObject) [!HAVE_PYTHON]: Define. > > * python/py-breakpoint.c (build_bp_list): Cast py_bp_object to > > PyObject pointer. > > (gdbpy_breakpoint_created): Remove casts around py_bp_object > > accesses. > > Thanks, Pedro! I confirm that this fixes the problem. > Can we check it in? (review needed?) Thanks for confirming. I've checked it in now. -- Pedro Alves