From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org, pmuldoon@redhat.com
Cc: Tom Tromey <tromey@redhat.com>, Joel Brobecker <brobecker@adacore.com>
Subject: Re: [RFA/Python] Fix procfs.c build failure on 32bit solaris (_FILE_OFFSET_BITS)
Date: Tue, 23 Nov 2010 17:47:00 -0000 [thread overview]
Message-ID: <201011231746.40560.pedro@codesourcery.com> (raw)
In-Reply-To: <m3fwushs47.fsf@redhat.com>
On Tuesday 23 November 2010 17:22:48, Phil Muldoon wrote:
> Pedro Alves <pedro@codesourcery.com> writes:
> > Here's a patch. We can move the PyObject fallback typedef from defs.h
> > to varobj.c again. I haven't looked to see if the PyObject pointers
> > in struct varobj have some other concrete type we could forward
> > declare instead. Or why don't we #ifdef out those fields if building
> > without python.
> >
> > Tested by building gdb with and without --with-python=no.
>
> I've no objection really, but wouldn't the PyObject typedef be better
> suited to defs.h?
It's only necessary in one file, and this is how it was before.
IMO, keeping it contained hints that we should avoid putting
uses of the type in core interfaces.
--
Pedro Alves
next prev parent reply other threads:[~2010-11-23 17:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-23 1:14 Joel Brobecker
2010-11-23 3:25 ` Jan Kratochvil
2010-11-23 12:42 ` Pedro Alves
2010-11-23 15:22 ` Tom Tromey
2010-11-23 16:29 ` Pedro Alves
2010-11-23 17:23 ` Phil Muldoon
2010-11-23 17:47 ` Pedro Alves [this message]
2010-11-24 17:20 ` Joel Brobecker
2010-11-25 13:12 ` Pedro Alves
2010-11-24 18:25 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201011231746.40560.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=pmuldoon@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox