From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9849 invoked by alias); 23 Nov 2010 17:47:01 -0000 Received: (qmail 9836 invoked by uid 22791); 23 Nov 2010 17:46:59 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 23 Nov 2010 17:46:45 +0000 Received: (qmail 10389 invoked from network); 23 Nov 2010 17:46:43 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 23 Nov 2010 17:46:43 -0000 From: Pedro Alves To: gdb-patches@sourceware.org, pmuldoon@redhat.com Subject: Re: [RFA/Python] Fix procfs.c build failure on 32bit solaris (_FILE_OFFSET_BITS) Date: Tue, 23 Nov 2010 17:47:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.33-29-realtime; KDE/4.4.5; x86_64; ; ) Cc: Tom Tromey , Joel Brobecker References: <1290474834-1945-1-git-send-email-brobecker@adacore.com> <201011231628.33851.pedro@codesourcery.com> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201011231746.40560.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00362.txt.bz2 On Tuesday 23 November 2010 17:22:48, Phil Muldoon wrote: > Pedro Alves writes: > > Here's a patch. We can move the PyObject fallback typedef from defs.h > > to varobj.c again. I haven't looked to see if the PyObject pointers > > in struct varobj have some other concrete type we could forward > > declare instead. Or why don't we #ifdef out those fields if building > > without python. > > > > Tested by building gdb with and without --with-python=no. > > I've no objection really, but wouldn't the PyObject typedef be better > suited to defs.h? It's only necessary in one file, and this is how it was before. IMO, keeping it contained hints that we should avoid putting uses of the type in core interfaces. -- Pedro Alves