Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Andrew Burgess <aburgess@broadcom.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Multi-dimensional Fortran arrays issue PR11104
Date: Tue, 23 Nov 2010 08:02:00 -0000	[thread overview]
Message-ID: <20101123080203.GA9228@host0.dyn.jankratochvil.net> (raw)
In-Reply-To: <89AE14E37D740B4796DC14566DF6325ECB7F8F140B@SJEXCHCCR02.corp.ad.broadcom.com>

On Wed, 17 Nov 2010 09:44:56 +0100, Andrew Burgess wrote:
> I'm happy to make any changes requested.

I find there a problem it does not check all the bounds like the compiler does.
I did not try to fix it up myself to say more.  Sorry for so late review.

gdb_test "print foo(0,4,4)" \
    "no such vector element" \
    "print an invalid array index (0,4,4)"

patched 7.2.50.20101123-cvs:
print foo(0,4,4)
$2 = 20
(gdb) FAIL: gdb.fortran/multi-dim.exp: print an invalid array index (0,4,4)

gcc-gfortran-4.5.1-4.fc14.x86_64:
  foo (0, 4, 4) = 20
Warning: Array reference at (1) is out of bounds (0 < 1) in dimension 1
Warning: Array reference at (1) is out of bounds (4 > 3) in dimension 2


Thanks,
Jan


  parent reply	other threads:[~2010-11-23  8:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-16 17:26 Andrew Burgess
2010-10-18  7:53 ` Andrew Burgess
2010-10-18 21:20   ` Jan Kratochvil
2010-10-19 16:23     ` Andrew Burgess
2010-11-17  8:45       ` Andrew Burgess
2010-11-22  7:10         ` Jan Kratochvil
2010-11-23  8:02         ` Jan Kratochvil [this message]
2010-11-23 10:04           ` Andrew Burgess
2010-11-23 17:23             ` Jan Kratochvil
2010-11-23 19:10               ` Jan Kratochvil
2010-10-18 21:21   ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101123080203.GA9228@host0.dyn.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=aburgess@broadcom.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox