From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5395 invoked by alias); 23 Nov 2010 08:02:19 -0000 Received: (qmail 5384 invoked by uid 22791); 23 Nov 2010 08:02:18 -0000 X-SWARE-Spam-Status: No, hits=-6.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 23 Nov 2010 08:02:13 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oAN82Bk3025343 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 23 Nov 2010 03:02:12 -0500 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id oAN827P1006343 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 23 Nov 2010 03:02:10 -0500 Received: from host0.dyn.jankratochvil.net (localhost.localdomain [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.4/8.14.4) with ESMTP id oAN826Sp009283; Tue, 23 Nov 2010 09:02:06 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.4/8.14.4/Submit) id oAN823h7009282; Tue, 23 Nov 2010 09:02:03 +0100 Date: Tue, 23 Nov 2010 08:02:00 -0000 From: Jan Kratochvil To: Andrew Burgess Cc: "gdb-patches@sourceware.org" Subject: Re: [PATCH] Multi-dimensional Fortran arrays issue PR11104 Message-ID: <20101123080203.GA9228@host0.dyn.jankratochvil.net> References: <89AE14E37D740B4796DC14566DF6325ECB7E173182@SJEXCHCCR02.corp.ad.broadcom.com> <89AE14E37D740B4796DC14566DF6325ECB7F0C2B39@SJEXCHCCR02.corp.ad.broadcom.com> <20101018211952.GA16206@host1.dyn.jankratochvil.net> <89AE14E37D740B4796DC14566DF6325ECB7F1F6E81@SJEXCHCCR02.corp.ad.broadcom.com> <89AE14E37D740B4796DC14566DF6325ECB7F8F140B@SJEXCHCCR02.corp.ad.broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <89AE14E37D740B4796DC14566DF6325ECB7F8F140B@SJEXCHCCR02.corp.ad.broadcom.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00344.txt.bz2 On Wed, 17 Nov 2010 09:44:56 +0100, Andrew Burgess wrote: > I'm happy to make any changes requested. I find there a problem it does not check all the bounds like the compiler does. I did not try to fix it up myself to say more. Sorry for so late review. gdb_test "print foo(0,4,4)" \ "no such vector element" \ "print an invalid array index (0,4,4)" patched 7.2.50.20101123-cvs: print foo(0,4,4) $2 = 20 (gdb) FAIL: gdb.fortran/multi-dim.exp: print an invalid array index (0,4,4) gcc-gfortran-4.5.1-4.fc14.x86_64: foo (0, 4, 4) = 20 Warning: Array reference at (1) is out of bounds (0 < 1) in dimension 1 Warning: Array reference at (1) is out of bounds (4 > 3) in dimension 2 Thanks, Jan