From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Andrew Burgess <aburgess@broadcom.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Multi-dimensional Fortran arrays issue PR11104
Date: Mon, 18 Oct 2010 21:20:00 -0000 [thread overview]
Message-ID: <20101018211952.GA16206@host1.dyn.jankratochvil.net> (raw)
In-Reply-To: <89AE14E37D740B4796DC14566DF6325ECB7F0C2B39@SJEXCHCCR02.corp.ad.broadcom.com>
On Mon, 18 Oct 2010 09:53:03 +0200, Andrew Burgess wrote:
> Was wondering if there was anything else I should do to get this patch
> considered for inclusion? I'm happy to make any changes required; this is my
> first gdb patch.
multi-dim.tar.bz2 (.exp + .f90) should be submitted as a normal patch, you can
at least do `diff -u /dev/null gdb/testsuite/gdb.fortran/file.exp'.
ChangeLog should be submitted as a text, not as patch.
There are several minor issues with formatting:
http://www.gnu.org/prep/standards/
(I have not yet checked the real code of the patch.)
This functionality is implemented by archer-jankratochvil-vla from:
http://sourceware.org/gdb/wiki/ArcherBranchManagement
(out of bounds access is not detected by the VLA patchset though)
which is currently not submitted for a review as it has more prerequisites.
Regards,
Jan
next prev parent reply other threads:[~2010-10-18 21:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-16 17:26 Andrew Burgess
2010-10-18 7:53 ` Andrew Burgess
2010-10-18 21:20 ` Jan Kratochvil [this message]
2010-10-19 16:23 ` Andrew Burgess
2010-11-17 8:45 ` Andrew Burgess
2010-11-22 7:10 ` Jan Kratochvil
2010-11-23 8:02 ` Jan Kratochvil
2010-11-23 10:04 ` Andrew Burgess
2010-11-23 17:23 ` Jan Kratochvil
2010-11-23 19:10 ` Jan Kratochvil
2010-10-18 21:21 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101018211952.GA16206@host1.dyn.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=aburgess@broadcom.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox