From: Joel Brobecker <brobecker@adacore.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Fix --enable-plugins --without-python
Date: Tue, 02 Nov 2010 18:43:00 -0000 [thread overview]
Message-ID: <20101102184341.GF2492@adacore.com> (raw)
In-Reply-To: <20101017104101.GA9276@host1.dyn.jankratochvil.net>
> gdb/
> 2010-10-17 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> Fix configure --enable-plugins --without-python.
> * configure.ac (for ELF support in BFD) <"$plugins" = "yes">: New.
> * configure: Regenerate.
Grumpf! It would be nice if BFD was telling us which libraries we need
to link against bfd, just as Gtk+, Python, etc, do.
I'm a little concern that this is a bit primitive, and good enough only
on GNU/Linux or maybe Unix. Or rather, that this might break the build
on some platforms such as Windows. But that's not the case, since
the user would need to use --enable-plugins to enable plugins (it's
not automatic), so I don't see a better solution that's actually
worth the effort.
> +if test "$plugins" = "yes"; then
> + LIBS="-ldl $LIBS"
> +fi
A comment explaining the dependency would be nice (likewise below).
> + if test "$plugins" = "yes"; then
> + OLD_LIBS="-ldl $OLD_LIBS"
> + fi
--
Joel
next prev parent reply other threads:[~2010-11-02 18:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-17 10:41 Jan Kratochvil
2010-11-02 18:43 ` Joel Brobecker [this message]
2010-11-05 1:52 ` Jan Kratochvil
2010-11-05 9:08 ` Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101102184341.GF2492@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox