From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19471 invoked by alias); 2 Nov 2010 18:43:54 -0000 Received: (qmail 19463 invoked by uid 22791); 2 Nov 2010 18:43:53 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 02 Nov 2010 18:43:49 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 09F612BAC58; Tue, 2 Nov 2010 14:43:47 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id d2gj4ZjWItdq; Tue, 2 Nov 2010 14:43:46 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 9A2292BACAF; Tue, 2 Nov 2010 14:43:46 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id AA69AF588F; Tue, 2 Nov 2010 11:43:41 -0700 (PDT) Date: Tue, 02 Nov 2010 18:43:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch] Fix --enable-plugins --without-python Message-ID: <20101102184341.GF2492@adacore.com> References: <20101017104101.GA9276@host1.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101017104101.GA9276@host1.dyn.jankratochvil.net> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00039.txt.bz2 > gdb/ > 2010-10-17 Jan Kratochvil > > Fix configure --enable-plugins --without-python. > * configure.ac (for ELF support in BFD) <"$plugins" = "yes">: New. > * configure: Regenerate. Grumpf! It would be nice if BFD was telling us which libraries we need to link against bfd, just as Gtk+, Python, etc, do. I'm a little concern that this is a bit primitive, and good enough only on GNU/Linux or maybe Unix. Or rather, that this might break the build on some platforms such as Windows. But that's not the case, since the user would need to use --enable-plugins to enable plugins (it's not automatic), so I don't see a better solution that's actually worth the effort. > +if test "$plugins" = "yes"; then > + LIBS="-ldl $LIBS" > +fi A comment explaining the dependency would be nice (likewise below). > + if test "$plugins" = "yes"; then > + OLD_LIBS="-ldl $OLD_LIBS" > + fi -- Joel