Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: gdb-patches@sourceware.org
Subject: [patch] Fix --enable-plugins --without-python
Date: Sun, 17 Oct 2010 10:41:00 -0000	[thread overview]
Message-ID: <20101017104101.GA9276@host1.dyn.jankratochvil.net> (raw)

Hi,

currently --enable-plugins --without-python will:
Reading symbols from .../gdb...I'm sorry, Dave, I can't do that.  Symbol format `elf64-x86-64' unknown.

due to missing elfread.c due to:

 configure:14941: checking for ELF support in BFD
 configure:14960: gcc -o conftest -g -I./../include -I../bfd -I./../bfd     -L../bfd -L../libiberty conftest.c -lbfd -liberty  -lncurses -lz -lm    >&5
-configure:14960: $? = 0
-configure:14968: result: yes
+/usr/bin/ld: ../bfd/libbfd.a(plugin.o): undefined reference to symbol 'dlsym@@GLIBC_2.2.5'
+/usr/bin/ld: note: 'dlsym@@GLIBC_2.2.5' is defined in DSO /lib64/libdl.so.2 so try adding it to the linker command line
+[...]
+configure:14968: result: no

Tested on x86_64-fedora13-linux-gnu.

As bfd/ uses just:

bfd/configure.in
# AC_PLUGINS setting $plugins is called by ACX_LARGEFILE.
ACX_LARGEFILE
AM_CONDITIONAL(PLUGINS, test "$plugins" = "yes")

bfd/Makefile.am
if PLUGINS
LIBDL = -ldl
endif

and I believe bfd/ is assumed to have the same configure options as gdb/ (is
it?) proposing this patch.


Thanks,
Jan


gdb/
2010-10-17  Jan Kratochvil  <jan.kratochvil@redhat.com>

	Fix configure --enable-plugins --without-python.
	* configure.ac (for ELF support in BFD) <"$plugins" = "yes">: New.
	* configure: Regenerate.

--- a/gdb/configure.ac
+++ b/gdb/configure.ac
@@ -1838,6 +1838,9 @@ OLD_LIBS=$LIBS
 CFLAGS="$CFLAGS -I${srcdir}/../include -I../bfd -I${srcdir}/../bfd"
 LDFLAGS="$LDFLAGS -L../bfd -L../libiberty"
 intl=`echo $LIBINTL | sed 's,${top_builddir}/,,g'`
+if test "$plugins" = "yes"; then
+  LIBS="-ldl $LIBS"
+fi
 LIBS="-lbfd -liberty $intl $LIBS"
 AC_CACHE_CHECK([for ELF support in BFD], gdb_cv_var_elf,
 [AC_TRY_LINK(
@@ -1851,6 +1854,9 @@ if test $gdb_cv_var_elf = yes; then
   CONFIG_OBS="$CONFIG_OBS elfread.o"
   AC_DEFINE(HAVE_ELF, 1,
 	    [Define if ELF support should be included.])
+  if test "$plugins" = "yes"; then
+    OLD_LIBS="-ldl $OLD_LIBS"
+  fi
 fi
 CFLAGS=$OLD_CFLAGS
 LDFLAGS=$OLD_LDFLAGS


             reply	other threads:[~2010-10-17 10:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-17 10:41 Jan Kratochvil [this message]
2010-11-02 18:43 ` Joel Brobecker
2010-11-05  1:52   ` Jan Kratochvil
2010-11-05  9:08     ` Mark Kettenis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101017104101.GA9276@host1.dyn.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox