Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Ali Lakhia <lakhia@alumni.utexas.net>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Memory leak fixes
Date: Sat, 02 Oct 2010 00:57:00 -0000	[thread overview]
Message-ID: <20101002005651.GF6213@adacore.com> (raw)
In-Reply-To: <AANLkTi=gYU1ix8_8G3Ens28=XmZxwuQ+=pqGqfrmM+-T@mail.gmail.com>

Ali,

> Please see fixes for memory leaks.  My testing for these has been
> limited to just making sure things work for my day-to-day use. Thanks,

First and foremost, thanks a lot for your submissions. A couple
of things, however, mostly procedural, I'm afraid:

  1. Your contributions are reaching a point where we can no longer
     take them under the `tiny change' rule.  The rule of thumb is
     around 15 lines, and you are well beyond that.  So, for us to
     continue incorporating your changes, we'll need a copyright
     assignment on file.

     I can get you started on the paperwork, if you would agree to
     assigning your GDB changes to the FSF.

  2. Changes in bfd should be sent as a separate patch to binutils.
     Please see the binutils/MAINTAINERS file for more details.

  3. Changes in GDB should be submitted following a procedure that
     is documented in gdb/CONTRIBUTE.  You're almost complient,
     but you're missing at least the ChangeLog entry.  Also, we
     really appreciate if you can run the testsuite before submitting
     the change.  Running the testsuite before and after your patch
     should not reveal any regression.

-- 
Joel


  reply	other threads:[~2010-10-02  0:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-02  0:16 Ali Lakhia
2010-10-02  0:57 ` Joel Brobecker [this message]
2010-10-05 22:47 ` Tom Tromey
2010-10-05 23:47   ` Ali Lakhia
2010-10-06 16:19     ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101002005651.GF6213@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=lakhia@alumni.utexas.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox