From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18832 invoked by alias); 2 Oct 2010 00:57:03 -0000 Received: (qmail 18816 invoked by uid 22791); 2 Oct 2010 00:57:02 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 02 Oct 2010 00:56:58 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 554722BACF2; Fri, 1 Oct 2010 20:56:56 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id AKiPCroBXTj8; Fri, 1 Oct 2010 20:56:56 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 169342BACEC; Fri, 1 Oct 2010 20:56:55 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 7FC29F591F; Fri, 1 Oct 2010 17:56:51 -0700 (PDT) Date: Sat, 02 Oct 2010 00:57:00 -0000 From: Joel Brobecker To: Ali Lakhia Cc: gdb-patches@sourceware.org Subject: Re: [patch] Memory leak fixes Message-ID: <20101002005651.GF6213@adacore.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-10/txt/msg00019.txt.bz2 Ali, > Please see fixes for memory leaks. My testing for these has been > limited to just making sure things work for my day-to-day use. Thanks, First and foremost, thanks a lot for your submissions. A couple of things, however, mostly procedural, I'm afraid: 1. Your contributions are reaching a point where we can no longer take them under the `tiny change' rule. The rule of thumb is around 15 lines, and you are well beyond that. So, for us to continue incorporating your changes, we'll need a copyright assignment on file. I can get you started on the paperwork, if you would agree to assigning your GDB changes to the FSF. 2. Changes in bfd should be sent as a separate patch to binutils. Please see the binutils/MAINTAINERS file for more details. 3. Changes in GDB should be submitted following a procedure that is documented in gdb/CONTRIBUTE. You're almost complient, but you're missing at least the ChangeLog entry. Also, we really appreciate if you can run the testsuite before submitting the change. Running the testsuite before and after your patch should not reveal any regression. -- Joel