From: Yao Qi <yao@codesourcery.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: dan@codesourcery.com, gdb-patches@sourceware.org
Subject: Re: [Patch,ARM] Next pc of sigreturn/rt_sigreturn syscall
Date: Mon, 30 Aug 2010 15:35:00 -0000 [thread overview]
Message-ID: <20100830153446.GC2482@qiyaows> (raw)
In-Reply-To: <201008301307.o7UD7Gm1022317@glazunov.sibelius.xs4all.nl>
On Mon, Aug 30, 2010 at 03:07:16PM +0200, Mark Kettenis wrote:
> > Date: Mon, 30 Aug 2010 08:59:58 -0400
> > From: Daniel Jacobowitz <dan@codesourcery.com>
> >
> > On Thu, Aug 26, 2010 at 04:50:48PM +0800, Yao Qi wrote:
> > > > Why did you remove the condition_true check?
> > >
> > > Because I noticed that condition_true always returns true if cond is 0xf
> > > (INST_NV).
> >
> > Sorry, you're right - I completely misread this.
> >
> > > 2010-08-26 Yao Qi <yao@codesourcery.com>
> > >
> > > * arm-linux-tdep.c (arm_linux_sigreturn_return_addr): New.
> > > (arm_linux_syscall_next_pc): New.
> > > (arm_linux_copy_svc): Use arm_linux_sigreturn_return_addr instead.
> > > (arm_linux_init_abi): Initialize syscall_next_pc.
> > > * arm-tdep.c (thumb_get_next_pc_raw): Get next pc of SWI in Thumb mode.
> > > (arm_get_next_pc_raw): Get next pc of SWI in ARM mode.
> > > * arm-tdep.h (struct gdbarch_tdep): Add a function pointer syscall_next_pc.
> > > Declare arm_frame_is_thumb.
> >
> > This is OK. Thanks!
>
> If Daniel is happy with this, I'm as well.
Committed in both GDB mainline and GDB 7.2 branch.
http://www.cygwin.org/ml/gdb-cvs/2010-08/msg00190.html
http://www.cygwin.org/ml/gdb-cvs/2010-08/msg00191.html
--
Yao Qi
CodeSourcery
yao@codesourcery.com
(650) 331-3385 x739
prev parent reply other threads:[~2010-08-30 15:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-24 6:39 Yao Qi
2010-08-24 11:28 ` Mark Kettenis
2010-08-24 14:13 ` Daniel Jacobowitz
2010-08-25 3:06 ` Yao Qi
2010-08-25 14:31 ` Daniel Jacobowitz
2010-08-26 8:51 ` Yao Qi
2010-08-30 13:00 ` Daniel Jacobowitz
2010-08-30 13:08 ` Mark Kettenis
2010-08-30 15:35 ` Yao Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100830153446.GC2482@qiyaows \
--to=yao@codesourcery.com \
--cc=dan@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox