From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19894 invoked by alias); 30 Aug 2010 15:35:39 -0000 Received: (qmail 19885 invoked by uid 22791); 30 Aug 2010 15:35:39 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 30 Aug 2010 15:34:57 +0000 Received: (qmail 2641 invoked from network); 30 Aug 2010 15:34:54 -0000 Received: from unknown (HELO qiyaows) (yao@127.0.0.2) by mail.codesourcery.com with ESMTPA; 30 Aug 2010 15:34:54 -0000 Date: Mon, 30 Aug 2010 15:35:00 -0000 From: Yao Qi To: Mark Kettenis Cc: dan@codesourcery.com, gdb-patches@sourceware.org Subject: Re: [Patch,ARM] Next pc of sigreturn/rt_sigreturn syscall Message-ID: <20100830153446.GC2482@qiyaows> References: <20100824063854.GA29794@codesourcery.com> <201008241127.o7OBR38E024928@glazunov.sibelius.xs4all.nl> <20100824141253.GA13547@caradoc.them.org> <20100825030554.GC29794@codesourcery.com> <20100825143137.GG28036@caradoc.them.org> <4C762AE8.4080307@codesourcery.com> <20100830125957.GW28036@caradoc.them.org> <201008301307.o7UD7Gm1022317@glazunov.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201008301307.o7UD7Gm1022317@glazunov.sibelius.xs4all.nl> User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00521.txt.bz2 On Mon, Aug 30, 2010 at 03:07:16PM +0200, Mark Kettenis wrote: > > Date: Mon, 30 Aug 2010 08:59:58 -0400 > > From: Daniel Jacobowitz > > > > On Thu, Aug 26, 2010 at 04:50:48PM +0800, Yao Qi wrote: > > > > Why did you remove the condition_true check? > > > > > > Because I noticed that condition_true always returns true if cond is 0xf > > > (INST_NV). > > > > Sorry, you're right - I completely misread this. > > > > > 2010-08-26 Yao Qi > > > > > > * arm-linux-tdep.c (arm_linux_sigreturn_return_addr): New. > > > (arm_linux_syscall_next_pc): New. > > > (arm_linux_copy_svc): Use arm_linux_sigreturn_return_addr instead. > > > (arm_linux_init_abi): Initialize syscall_next_pc. > > > * arm-tdep.c (thumb_get_next_pc_raw): Get next pc of SWI in Thumb mode. > > > (arm_get_next_pc_raw): Get next pc of SWI in ARM mode. > > > * arm-tdep.h (struct gdbarch_tdep): Add a function pointer syscall_next_pc. > > > Declare arm_frame_is_thumb. > > > > This is OK. Thanks! > > If Daniel is happy with this, I'm as well. Committed in both GDB mainline and GDB 7.2 branch. http://www.cygwin.org/ml/gdb-cvs/2010-08/msg00190.html http://www.cygwin.org/ml/gdb-cvs/2010-08/msg00191.html -- Yao Qi CodeSourcery yao@codesourcery.com (650) 331-3385 x739