From: Daniel Jacobowitz <dan@codesourcery.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>, Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [Patch,ARM] Next pc of sigreturn/rt_sigreturn syscall
Date: Tue, 24 Aug 2010 14:13:00 -0000 [thread overview]
Message-ID: <20100824141253.GA13547@caradoc.them.org> (raw)
In-Reply-To: <201008241127.o7OBR38E024928@glazunov.sibelius.xs4all.nl>
On Tue, Aug 24, 2010 at 01:27:03PM +0200, Mark Kettenis wrote:
> > Date: Mon, 23 Aug 2010 23:38:54 -0700
> > From: Yao Qi <yao@codesourcery.com>
> >
> > Hi,
> > This patch is to calculate correct address of 'next pc' of syscall
> > sigreturn and rt_sigreturn.
>
> You're polluting the genric arm code with Linux-specific stuff.
> Please don't do that. If something like this is needed, it should be
> added to code in arm-linux-tdep.c.
There's a couple of ways to do that; one example is
mips_linux_syscall_next_pc.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2010-08-24 14:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-24 6:39 Yao Qi
2010-08-24 11:28 ` Mark Kettenis
2010-08-24 14:13 ` Daniel Jacobowitz [this message]
2010-08-25 3:06 ` Yao Qi
2010-08-25 14:31 ` Daniel Jacobowitz
2010-08-26 8:51 ` Yao Qi
2010-08-30 13:00 ` Daniel Jacobowitz
2010-08-30 13:08 ` Mark Kettenis
2010-08-30 15:35 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100824141253.GA13547@caradoc.them.org \
--to=dan@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox