From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13801 invoked by alias); 24 Aug 2010 14:13:09 -0000 Received: (qmail 13751 invoked by uid 22791); 24 Aug 2010 14:13:08 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 24 Aug 2010 14:13:03 +0000 Received: (qmail 15926 invoked from network); 24 Aug 2010 14:13:00 -0000 Received: from unknown (HELO caradoc.them.org) (dan@127.0.0.2) by mail.codesourcery.com with ESMTPA; 24 Aug 2010 14:13:00 -0000 Date: Tue, 24 Aug 2010 14:13:00 -0000 From: Daniel Jacobowitz To: Mark Kettenis , Yao Qi Cc: gdb-patches@sourceware.org Subject: Re: [Patch,ARM] Next pc of sigreturn/rt_sigreturn syscall Message-ID: <20100824141253.GA13547@caradoc.them.org> Mail-Followup-To: Mark Kettenis , Yao Qi , gdb-patches@sourceware.org References: <20100824063854.GA29794@codesourcery.com> <201008241127.o7OBR38E024928@glazunov.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201008241127.o7OBR38E024928@glazunov.sibelius.xs4all.nl> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00409.txt.bz2 On Tue, Aug 24, 2010 at 01:27:03PM +0200, Mark Kettenis wrote: > > Date: Mon, 23 Aug 2010 23:38:54 -0700 > > From: Yao Qi > > > > Hi, > > This patch is to calculate correct address of 'next pc' of syscall > > sigreturn and rt_sigreturn. > > You're polluting the genric arm code with Linux-specific stuff. > Please don't do that. If something like this is needed, it should be > added to code in arm-linux-tdep.c. There's a couple of ways to do that; one example is mips_linux_syscall_next_pc. -- Daniel Jacobowitz CodeSourcery